Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Accessibility update / Tested for frontend-subsidiepunt #508

Merged
merged 10 commits into from
Sep 5, 2024
Merged

Accessibility update / Tested for frontend-subsidiepunt #508

merged 10 commits into from
Sep 5, 2024

Conversation

Dietr
Copy link
Contributor

@Dietr Dietr commented Sep 5, 2024

Accessibility fixes:

  • Fix AuDataTable sortable header color contrast
  • Fix secondary helptext color contrast
  • Remove aria-controls from aria-live region: not a valid property

Documentation update:

  • fix dropdown example: role=menu should not be on the dropdown button

Additions:

  • AuMainHeader: add override on the contact link text. Certain products apply a hack to put a different link which breaks the semantics of this component

@Dietr Dietr requested a review from Windvis September 5, 2024 09:38
@Windvis Windvis added the enhancement Used when the PR adds a new feature or enhancement. label Sep 5, 2024
Windvis
Windvis approved these changes Sep 5, 2024
View reviewed changes
addon/components/au-main-header.gts Outdated Show resolved Hide resolved
stories/5-components/Navigation/AuDropdown.stories.js Show resolved Hide resolved
@Windvis Windvis merged commit 3c89144 into master Sep 5, 2024
8 checks passed
@Windvis Windvis deleted the feature/accessibility-update branch September 5, 2024 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Windvis Windvis Windvis approved these changes

Assignees
No one assigned
Labels
enhancement Used when the PR adds a new feature or enhancement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Dietr @Windvis