Add support for displaying multiple modals at the same time #476
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…aced (see in-element docs), make backdrop and modal z-index the same, so new modals can be shown over existing modals
Windvis
reviewed
Mar 11, 2024
There was a problem hiding this comment.
Looks good, and seems to work as expected when I try it in the storybook app. 👍
Could you maybe add a simple test to this file that verifies that multiple modal components can be rendered at the same time? Just checking that both are in the DOM should be good enough I think.
styles/components/_c-modal.scss
Outdated
| @@ -6,7 +6,7 @@ | |||
| ========================================================================== */ | |||
|
|
|||
| $au-modal-z-index: 9999 !default; | |||
| $au-modal-backdrop-z-index: 9998 !default; | |||
| $au-modal-backdrop-z-index: 9999 !default; | |||
There was a problem hiding this comment.
Question: Does it still make sense to make this configurable after this change? For this to work properly both z-index values need to be the same I think?
There was a problem hiding this comment.
indeed it should be the same. I wanted to keep it around in case others would use this property, but if you prefer i can remove it instead?
Windvis
added
the
enhancement
Windvis
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the previous behaviour broke opening a modal when another modal was already open because focus-trap tried to access the previous modal's contents which broke the app.