Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an isOpenInitially argument to the AuAccordion component #469

Merged
merged 3 commits into from
Feb 16, 2024

Conversation

Windvis
Copy link
Contributor

@Windvis Windvis commented Feb 15, 2024

This adds a new defaultOpen isOpenInitially argument to the AuAccordion component which can be used to display the accordion in the open state from the start.

It also adds Glint support to component (also to the AuToolbar component, since that's one of its dependencies.)

Closes #461

@Windvis Windvis force-pushed the chore/accordion-default-open-state branch from bc126a1 to 1f2e4c0 Compare February 15, 2024 15:22
@Windvis
Copy link
Contributor Author

Windvis commented Feb 15, 2024

@aliokan I've used the defaultOpen name since that's how it was described in the issue. I did notice we already have a similar argument for the AuCard component but it's called isOpenInitially. I think it makes sense to make these somewhat consistent?

So we could rename it here, or add support for defaultOpen to the other one as well. (Or just keep it as-is) Any opinions?

@aliokan
Copy link

aliokan commented Feb 16, 2024

@Windvis Thank for the update! 🙏

As I can see, AuCard isOpenInitially is already use in different places: https://github.com/search?q=org%3Alblod%20isOpenInitially&type=code
In order to avoid breaking changes, I would also use isOpenInitially in the accordion.

@Windvis Windvis added the enhancement Used when the PR adds a new feature or enhancement. label Feb 16, 2024
@Windvis Windvis force-pushed the chore/accordion-default-open-state branch from 1f2e4c0 to 7b6bdb0 Compare February 16, 2024 13:56
@Windvis Windvis changed the title Add a defaultOpen argument to the AuAccordion component Add a isOpenInitially argument to the AuAccordion component Feb 16, 2024
@Windvis Windvis changed the title Add a isOpenInitially argument to the AuAccordion component Add an isOpenInitially argument to the AuAccordion component Feb 16, 2024
@Windvis Windvis merged commit 0916aec into master Feb 16, 2024
8 checks passed
@Windvis Windvis deleted the chore/accordion-default-open-state branch February 16, 2024 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Used when the PR adds a new feature or enhancement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AuAccordion - Add defaultOpen argument
2 participants