Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate the tertiary button skin #433

Merged
merged 3 commits into from
Sep 15, 2023

Conversation

Windvis
Copy link
Contributor

@Windvis Windvis commented Sep 15, 2023

It seems this was marked as deprecated in the code, but a deprecation message was never added. This adds that so we can remove it in v3.

This is an alias for the link skin so it can simply be renamed.

This is an alias for the `link` skin so it can simply be renamed.

It seems this was marked as deprecated in the code, but a deprecation message was never added. This adds that so we can remove it in v3.
This also makes the pagination in the DataTable story interactive so that we can test it easier.
@Windvis Windvis added enhancement Used when the PR adds a new feature or enhancement. Deprecation This change introduces a deprecation. A simple guide should be provided in the description. labels Sep 15, 2023
@Windvis Windvis merged commit 01680ca into master Sep 15, 2023
10 checks passed
@Windvis Windvis deleted the feat/deprecate-tertiary-button-skin branch September 15, 2023 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Deprecation This change introduces a deprecation. A simple guide should be provided in the description. enhancement Used when the PR adds a new feature or enhancement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant