Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Faulty vertical alignment of button & link components #328

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

brenner-company
Copy link
Collaborator

@brenner-company brenner-company commented Oct 5, 2022

The following issue is visible when two or more successive AuButton or AuLink components with one having an icon with left alignment and the other having an icon with left alignment (or even no icon) are displayed: the elements will be vertically aligned in an incorrect way (see screenshot below).

CleanShot 2022-09-14 at 14 31 43@2x

@brenner-company brenner-company added the bug Used when the PR fixes a bug included in a previous release. label Oct 5, 2022
@brenner-company brenner-company requested a review from Dietr October 5, 2022 22:17
@brenner-company brenner-company marked this pull request as draft October 5, 2022 22:47
@brenner-company
Copy link
Collaborator Author

@Dietr I'm putting this PR on hold for a moment. I'm seeing some minor visual (vertical) jump issues within Chromatic that I didn't experience within Kaleidos.

@Dietr
Copy link
Contributor

Dietr commented Oct 6, 2022

The visual changes seem fine to me. Will do a check in some other applications to see if it breaks anything.

@Windvis Windvis changed the base branch from development to master January 9, 2023 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Used when the PR fixes a bug included in a previous release.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants