Skip to content

Commit

Permalink
Resolve some issues with `babel-plugin-ember-template-compilation
Browse files Browse the repository at this point in the history
v2.2.2`

The v2.2.2 release breaks our ember-template-imports v3 based setup.

We need to update to v4 to fix those and also fix the scope issues we
accidentally depended on.
  • Loading branch information
Windvis committed May 8, 2024
1 parent 635c139 commit b59a62a
Show file tree
Hide file tree
Showing 3 changed files with 195 additions and 60 deletions.
247 changes: 191 additions & 56 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -94,7 +94,7 @@
"ember-file-upload": "^8.4.0",
"ember-focus-trap": "^1.1.0",
"ember-modifier": "^4.1.0",
"ember-template-imports": "^3.4.2",
"ember-template-imports": "^4.1.0",
"ember-test-selectors": "^6.0.0",
"ember-truth-helpers": "^3.1.1 || ^4.0.3",
"inputmask": "^5.0.9-beta.45",
Expand Down Expand Up @@ -214,6 +214,6 @@
}
},
"volta": {
"node": "18.18.0"
"node": "18.20.2"
}
}
4 changes: 2 additions & 2 deletions tests/integration/modifiers/au-date-input-test.gts
Original file line number Diff line number Diff line change
Expand Up @@ -67,9 +67,9 @@ module('Integration | Modifier | au-date-input', function (hooks) {
</template>,
);

const input = find('input');
const inputElement = find('input');

await clearInput(input!);
await clearInput(inputElement!);
assert.verifySteps(
['true', 'true'],
'`@onChange` returns `null` if the input is cleared',
Expand Down

0 comments on commit b59a62a

Please sign in to comment.