Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use alert-patching.libsonnet to render our alerts #76

Merged
merged 2 commits into from
Nov 15, 2022

Conversation

simu
Copy link
Member

@simu simu commented Nov 15, 2022

We've added a component library for patching and filtering alerts in appuio/component-openshift4-monitoring#136 which is released in component opneshift4-monitoring v2.9.0.

This PR uses the library to replace the copy-pasted logic to patch alerts managed by this component.

Checklist

  • PR contains a single logical change (to build a better changelog).
  • Categorize the PR by setting a good title and adding one of the labels:
    bug, enhancement, documentation, change, breaking, dependency
    as they show up in the changelog.
  • Link this PR to related issues or PRs.

simu added 2 commits November 15, 2022 14:17
We already use `com.getValueOrDefault()` as a fall back if parameter
`openshift4_monitoring` isn't present in the hierarchy.
@simu simu added the change label Nov 15, 2022
@simu simu requested a review from bastjan November 15, 2022 15:43
@simu simu merged commit 32bf3c4 into master Nov 15, 2022
@simu simu deleted the feat/use-alert-patching-lib branch November 15, 2022 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants