Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Match default requests with the platform's ratio #90

Merged
merged 1 commit into from
Apr 11, 2022
Merged

Match default requests with the platform's ratio #90

merged 1 commit into from
Apr 11, 2022

Conversation

corvus-ch
Copy link
Contributor

@corvus-ch corvus-ch commented Apr 11, 2022 •
edited
Loading

I ended up creating this PR while I was refining https://ticket.vshn.net/browse/APUB-273.

Checklist

  • PR contains a single logical change (to build a better changelog).
  • Update the documentation.
  • Categorize the PR by setting a good title and adding one of the labels:
    bug, enhancement, documentation, change, breaking, dependency
    as they show up in the changelog.
  • Link this PR to related issues or PRs.

@corvus-ch corvus-ch requested a review from a team April 11, 2022 12:46
@corvus-ch corvus-ch force-pushed the default-requests-ratio branch from b95cbe0 to e498d5b Compare April 11, 2022 13:17
simu
simu reviewed Apr 11, 2022
View reviewed changes
Copy link
Member

@simu simu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also needs a make gen-policy-docs

class/defaults.yml Outdated Show resolved Hide resolved
@corvus-ch corvus-ch force-pushed the default-requests-ratio branch from e498d5b to 2e5f28a Compare April 11, 2022 13:27
@corvus-ch corvus-ch force-pushed the default-requests-ratio branch from 2e5f28a to 897e47e Compare April 11, 2022 13:31
@corvus-ch corvus-ch requested a review from simu April 11, 2022 13:31
@corvus-ch corvus-ch merged commit e5ea54a into master Apr 11, 2022
@corvus-ch corvus-ch deleted the default-requests-ratio branch April 11, 2022 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simu simu simu approved these changes

Assignees
No one assigned
Labels
change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@corvus-ch @simu