Add support to skip adding activeDeadlineSeconds to "run-once" pods based on their labels
#61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit introduces support for not adding `activeDeadlineSeconds` to RunOnce pods based on their labels. This can be useful to exclude some pods (e.g. cert-manager http01 solver pods) from the default deadline logic.
simu
requested review from
bastjan and
a team
and removed request for
bastjan
ccremer
approved these changes
Feb 1, 2022
Co-authored-by: Chris <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces support for not adding
activeDeadlineSecondsto "run-once" pods based on their labels.This can be useful to exclude some pods (e.g. cert-manager http01 solver pods) from the default deadline logic.
Checklist
bug,enhancement,documentation,change,breaking,dependencyas they show up in the changelog.