Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce ephemeral-storage quotas #19

Merged
merged 1 commit into from
Sep 27, 2021
Merged

Introduce ephemeral-storage quotas #19

merged 1 commit into from
Sep 27, 2021

Conversation

bastjan
Copy link
Contributor

@bastjan bastjan commented Sep 22, 2021

See https://kb.vshn.ch/appuio-cloud/references/quality-requirements/performance/resource-quota.html
(27.9.2021)
Or: https://github.com/appuio/appuio-io-docs/blob/2e11cb7729bc157e70778ced4e1ff52515d0504e/docs/modules/ROOT/pages/references/quality-requirements/performance/resource-quota.adoc

Checklist

  • Keep pull requests small so they can be easily reviewed.
  • Categorize the PR by setting a good title and adding one of the labels:
    bug, enhancement, documentation, change, breaking, dependency
    as they show up in the changelog

@bastjan bastjan added the change label Sep 22, 2021
@bastjan bastjan self-assigned this Sep 22, 2021
Copy link
Contributor

@ccremer ccremer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please link the KB article mentioned, to the PR description

class/defaults.yml Show resolved Hide resolved
@bastjan
Copy link
Contributor Author

bastjan commented Sep 27, 2021

Please link the KB article mentioned, to the PR description

https://github.com/appuio/component-appuio-cloud/pull/19/files#diff-6fd07ea8eb879a940d3dfb5e2d4f7bcb6f049795bc05fbd7f2dbbb7bc2f5c310L41

It's already mentioned a bit higher up.

@ccremer ccremer changed the title Introduce ephemeral-storage quotas. Set limits to values in KB article Introduce ephemeral-storage quotas Sep 27, 2021
@ccremer
Copy link
Contributor

ccremer commented Sep 27, 2021

to the PR description

It's already mentioned a bit higher up.

Yeah, I meant it would be nice to have a short summary in the PR. So if someone looks at the release changelog and clicks on this PR, one would not really need to comb through (collapsed) code when figuring out what has changed and why.

@bastjan
Copy link
Contributor Author

bastjan commented Sep 27, 2021

to the PR description

Sorry i missread 🤦‍♀️

class/defaults.yml Show resolved Hide resolved
@bastjan bastjan merged commit 607af4d into master Sep 27, 2021
@bastjan bastjan deleted the storage-quotas branch September 27, 2021 11:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants