Use request.userInfo.groups to validate the organization label
#14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simu
force-pushed
the
feat/simplify-namespace-organization-validation
branch
from
18cecae to
5b0c81d
Compare
simu
force-pushed
the
feat/simplify-namespace-organization-validation
branch
from
5b0c81d to
25c0b49
Compare
simu
changed the title
request.userInfo.groups to validate the organization label
simu
force-pushed
the
feat/simplify-namespace-organization-validation
branch
from
25c0b49 to
dd60540
Compare
simu
force-pushed
the
feat/simplify-namespace-organization-validation
branch
from
dd60540 to
870b56a
Compare
glrf
suggested changes
Sep 10, 2021
Kyverno provides the requesting user's groups in `request.userInfo.groups`. This commit changes the `is-in-organization` policy to use this variable instead of fetching all groups from the Kubernetes API when validating that the user is part of the organization specified on the Namespace object.
simu
force-pushed
the
feat/simplify-namespace-organization-validation
branch
from
870b56a to
cc506db
Compare
glrf
approved these changes
Sep 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Kyverno provides the requesting user's groups in
request.userInfo.groups.This commit changes the
is-in-organizationpolicy to use this variable instead of fetching all groups from the Kubernetes API when validating that the user is part of the organization specified on the Namespace object.Checklist
bug,enhancement,documentation,change,breaking,dependencyas they show up in the changelog