Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Option to clean cache items older than n days #5249

Merged
merged 4 commits into from
Apr 27, 2020
Merged

Option to clean cache items older than n days #5249

merged 4 commits into from
Apr 27, 2020

Conversation

dtrudg
Copy link
Contributor

@dtrudg dtrudg commented Apr 27, 2020

Description of the Pull Request (PR):

Return the ability to clean specific items from the cache, but do this
based on age, rather than a name. The hashes used in the cache aren't
really useful for cleaning specific items. Cleaning items older than n
days seems generally useful, and has been requested by users.

This fixes or addresses the following GitHub issues:

Before submitting a PR, make sure you have done the following:

Attn: @singularity-maintainers

@dtrudg dtrudg added this to the 3.6.0 milestone Apr 27, 2020
@dtrudg dtrudg self-assigned this Apr 27, 2020
dtrudg added 3 commits April 27, 2020 12:28
@dtrudg
Option to clean cache items older than n days
b95f8f8 
Fixes: #5095

Return the ability to clean specific items from the cache, but do this
based on age, rather than a name. The hashes used in the cache aren't
really useful for cleaning specific items. Cleaning items older than n
days seems generally useful, and has been requested by users.
@dtrudg
e2e tests for cache clean --days
579900f
@dtrudg
Simplify time.Now().Sub(..) to time.Since(..)
7904242
@dtrudg dtrudg requested review from EmmEff and tri-adam April 27, 2020 17:48
@dtrudg dtrudg marked this pull request as ready for review April 27, 2020 17:48
EmmEff
EmmEff approved these changes Apr 27, 2020
View reviewed changes
Copy link
Contributor

@EmmEff EmmEff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested various invocations (different days and types) with success. LGTM

EmmEff
EmmEff approved these changes Apr 27, 2020
View reviewed changes
Copy link
Contributor

@EmmEff EmmEff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@dtrudg
Copy link
Contributor Author

dtrudg commented Apr 27, 2020

Merging - Travis CI failure is related to status of the vault CentOS mirror.

@dtrudg dtrudg merged commit 50be76e into apptainer:master Apr 27, 2020
@dtrudg dtrudg deleted the issue5095 branch October 12, 2020 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EmmEff EmmEff EmmEff approved these changes

@tri-adam tri-adam Awaiting requested review from tri-adam

Assignees

@dtrudg dtrudg

Labels
None yet
Projects
None yet
Milestone
3.6.0
Development

Successfully merging this pull request may close these issues.

Cache clean for items older than x
2 participants
@dtrudg @EmmEff