Merge sylabs/sif up to the creation of v1 branch #105
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Address occasional SIGBUS when accessing SIF file stored on a non-local filesystem (#11) by removing mmap usage.
GetData returns nil on error. By using GetReadSeeker instead, a detailed error message can be reported.
The ReadWriter passed to LoadContainerFp may have a non-zero seek location. Extend LoadContainerFp unit test to provide coverage of this scenario.
The underlying source of headers/descriptors may contain a non-zero seek offset when LoadContainerFp is called. Switch to ReadAt so these code paths are unaffeected in this case.
Add GetReader and deprecate GetReadSeeker. Replace usage of GetReadSeeker with GetReader in integrity package.
Expose String() for Fstype, Parttype, Hashtype, Formattype, Messagetype types, to support the eventual removal of formatting functions from the SIF package.
Codecov Report
@@ Coverage Diff @@
## master #105 +/- ##
==========================================
+ Coverage 64.79% 65.08% +0.29%
==========================================
Files 11 12 +1
Lines 1440 1395 -45
==========================================
- Hits 933 908 -25
+ Misses 325 310 -15
+ Partials 182 177 -5
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
kmuriki
approved these changes
Aug 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This merges in all the commits from sylabs/sif up to the creation of the v1 branch, importing the following PRs:
Also fixes the following hpcng/sif issues:
After this the only differences between sylabs/sif and hpcng/sif at the time of the v1 branch are:
internal/app/siftool/modif.goorpkg/integrity/testdata/gen_sifs.go.