Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix DateTime conversion #33

Merged
merged 5 commits into from
Oct 16, 2022
Merged

Fix DateTime conversion #33

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
562b489
Fix DateTime / Duration conversion
pingbird Sep 17, 2021
3a7b9e2
Add tests
pingbird Sep 21, 2021
2cd2c96
Remove .idea
pingbird Sep 21, 2021
887bac8
Remove extra test
pingbird Sep 21, 2021
1aadc5f
Remove .idea
pingbird Sep 21, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions lib/src/util.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,9 +88,10 @@ class JsonObject {
case Uri:
return Uri.parse(v) as T;
case DateTime:
return DateTime.fromMillisecondsSinceEpoch(v * 1000) as T;
return DateTime.fromMillisecondsSinceEpoch(((v as num).round() * 1000))
as T;
case Duration:
return Duration(seconds: v) as T;
return Duration(seconds: (v as num).round()) as T;
case String:
case num:
case bool:
Expand Down
9 changes: 7 additions & 2 deletions test/jwt_test.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import 'package:test/test.dart';
import 'package:jose/src/jwt.dart';
import 'package:jose/src/jwk.dart';
import 'package:jose/src/jwt.dart';
import 'package:test/test.dart';

void main() {
group('JWT Examples from RFC7519', () {
Expand Down Expand Up @@ -153,4 +153,9 @@ void main() {
'AVO9iT5AV4CzvDJCdhSFlQ');
});
});

test('JsonWebTokenClaims can handle doubles in expiration', () {
final claims = JsonWebTokenClaims.fromJson({'exp': 1300819380.0});
expect(claims.expiry, DateTime.fromMillisecondsSinceEpoch(1300819380000));
});
}