This repository has been archived by the owner on Jul 27, 2023. It is now read-only.
nodejs-loopback: upgrade/add application dependencies #488
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raymondfeng
force-pushed
the
lb4-deps
branch
from
bac05f5 to
509ef01
Compare
neeraj-laad
suggested changes
Nov 20, 2019
There was a problem hiding this comment.
@raymondfeng Overall looks good. It seems like we have added metrics support in the stack. I believe we should update the README.md to reflect that capability is available from the stack.
To develop the application independent of the base image, we need to set up dependencies in application's package.json file.
raymondfeng
force-pushed
the
lb4-deps
branch
from
79e6f5f to
911cf4d
Compare
|
@neeraj-laad README updated. Thanks for the review. |
Kamran64
approved these changes
Nov 21, 2019
7 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To develop the application independent of the base image, we need to set up
dependencies in application's package.json file.
Checklist:
Read the Code of Conduct and Contributing Guidelines.
Followed the commit message guidelines.
Stack adheres to Appsody stack structure.
Modifying an existing stack:
stack.yamlContributing a new stack:
Describe how application dependencies are managed:
Explain how Appsody file watcher is utilized:
Describe other Appsody environment variables defined by the stack image:
Describe any limitations and known issues:
Related Issues: