Skip to content
This repository has been archived by the owner on Aug 6, 2024. It is now read-only.

feat: Added new maximize minimize icons #705

Merged
merged 2 commits into from
Feb 27, 2024

Conversation

albinAppsmith
Copy link
Contributor

@albinAppsmith albinAppsmith commented Feb 27, 2024

Description

Added updated v3 icons for minimize and maximize.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

  • Manual on storybook
  • Manual on main repo
  • Jest
  • Cypress

Test Plan

Add Testsmith test cases links that relate to this PR

Issues raised during DP testing

Link issues raised during DP testing for better visiblity and tracking (copy link from comments dropped on this PR)

Checklist:

Dev activity

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

QA activity:

  • Test plan has been approved by relevant developers
  • Test plan has been peer reviewed by QA
  • Cypress test cases have been added and approved by either SDET or manual QA
  • Organized project review call with relevant stakeholders after Round 1/2 of QA
  • Added Test Plan Approved label after reveiwing all Cypress test

Copy link

changeset-bot bot commented Feb 27, 2024

🦋 Changeset detected

Latest commit: c2f8c4f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@appsmithorg/design-system Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Feb 27, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
design-system ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 27, 2024 6:51am

@albinAppsmith albinAppsmith merged commit 2c65e1e into release Feb 27, 2024
13 of 14 checks passed
@albinAppsmith albinAppsmith deleted the new-minimize-maximize-icon branch February 27, 2024 06:49
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants