Skip to content
This repository has been archived by the owner on Aug 6, 2024. It is now read-only.

feat: Added flex component #647

Merged
merged 24 commits into from
Oct 13, 2023
Merged

feat: Added flex component #647

merged 24 commits into from
Oct 13, 2023

Conversation

albinAppsmith
Copy link
Contributor

@albinAppsmith albinAppsmith commented Oct 5, 2023

Description

This PR addes the Flex component.

Fixes appsmithorg/appsmith#27607
Fixes appsmithorg/appsmith#27608
Fixes appsmithorg/appsmith#27606

Type of change

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

  • Manual on storybook
  • Manual on main repo
  • Jest
  • Cypress

Test Plan

Add Testsmith test cases links that relate to this PR

Issues raised during DP testing

Link issues raised during DP testing for better visiblity and tracking (copy link from comments dropped on this PR)

Checklist:

Dev activity

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

QA activity:

  • Test plan has been approved by relevant developers
  • Test plan has been peer reviewed by QA
  • Cypress test cases have been added and approved by either SDET or manual QA
  • Organized project review call with relevant stakeholders after Round 1/2 of QA
  • Added Test Plan Approved label after reveiwing all Cypress test

@changeset-bot
Copy link

changeset-bot bot commented Oct 5, 2023

⚠️ No Changeset found

Latest commit: 4b554c2

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes changesets to release 1 package
Name Type
@appsmithorg/design-system Patch

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Oct 5, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
design-system ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 13, 2023 10:56am

@albinAppsmith albinAppsmith requested a review from KelvinOm October 5, 2023 04:54
Copy link

@KelvinOm KelvinOm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@albinAppsmith what is the difference between Flex and #644 components and what is the reason to have both of them?

@albinAppsmith
Copy link
Contributor Author

@albinAppsmith what is the difference between Flex and #644 components and what is the reason to have both of them?

@KelvinOm I have made the box component as private and not export it outside the package. And for grid and flex I'm using it.

Copy link

@KelvinOm KelvinOm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. @jsartisan Could you also take a look?

KelvinOm
KelvinOm previously approved these changes Oct 13, 2023
jsartisan
jsartisan previously approved these changes Oct 13, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
3 participants