test: Update Inline_editing_3_spec.js to include expected JSON parsing

[rahulbarwal]

Description

Root cause
This spec was failing because it was string comparing the values, whereas the source was a JS Object. This sometimes caused spec to fail.

Solution
This pull request updates the Inline_editing_3_spec.js file to include the expected JSON parsing. The changes ensure that the correct JSON parsing is performed when editing a table cell and saving the changes.

Fixes #36720
or
Fixes Issue URL

Warning

If no issue exists, please create an issue first, and check with the maintainers if the issue is valid.

Automation

/ok-to-test tags="@tag.Table"

🔍 Cypress test results

Tip

🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/11211620961
Commit: 0cf810b
Cypress dashboard.
Tags: @tag.Table
Spec:

---

Mon, 07 Oct 2024 09:27:17 UTC

Communication

Should the DevRel and Marketing teams inform users about this change?

• Yes
• No

Summary by CodeRabbit

• Bug Fixes

  • Improved validation for inline editing functionality in table widget tests.
  • Enhanced assertions for save/discard operations to ensure accuracy after changes.
  • Added checks for various column types in the onsubmit event tests.

• Tests

  • Expanded end-to-end tests for inline editing, ensuring thorough validation across scenarios.
  • Incorporated additional checks for the display and retention of values during editing operations.

[coderabbitai]

Walkthrough

The pull request modifies the Cypress end-to-end tests for the inline editing functionality of a table widget. It includes enhancements to assertions, updates to element checks, and validations for saving and discarding changes. The tests now ensure that the inline cell editor behaves correctly and that the state of the table reflects changes accurately after operations. Overall, these adjustments aim to improve the reliability and thoroughness of the testing framework.

Changes

Files	Change Summary
app/client/cypress/e2e/Regression/ClientSide/Widgets/TableV2/Inline_editing_3_spec.js	- Updated assertions and element checks for inline editing functionality. - Enhanced tests for editable cells and discard functionality. - Added wait periods for saving changes. - Improved validation for updated rows and indices. - Expanded checks for onsubmit and onSave events.

Assessment against linked issues

Objective	Addressed	Explanation
Fix failing spec (#[36720])	✅

Possibly related PRs

• feat: Allow table search to include label and value for tables with select column type #36061: Enhances test specifications for the TableV2 component, relating to the inline editing functionality.
• fix: Inline editing flaky test fix #36366: Addresses issues with flaky tests for inline editing, connecting directly to the main PR's focus.

Suggested labels

Bug

Suggested reviewers

• ApekshaBhosale
• sagar-qa007

In the realm of tests, we strive to be keen,
With assertions and checks, we keep our code clean.
Inline editing's magic, we now verify,
With Cypress in hand, our tests reach the sky!
So let’s save and discard, with joy and delight,
For a robust codebase, we’ll continue the fight! 🎉

---

📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL

📥 Commits

Files that changed from the base of the PR and between 9d93a8f and 0cf810b.

📒 Files selected for processing (1)

• app/client/cypress/e2e/Regression/ClientSide/Widgets/TableV2/Inline_editing_3_spec.js (2 hunks)

🚧 Files skipped from review as they are similar to previous changes (1)

• app/client/cypress/e2e/Regression/ClientSide/Widgets/TableV2/Inline_editing_3_spec.js

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 3

📜 Review details

Configuration used: .coderabbit.yaml
Review profile: CHILL

📥 Commits

Files that changed from the base of the PR and between 28e54fe and 9d93a8f.

📒 Files selected for processing (1)

• app/client/cypress/e2e/Regression/ClientSide/Widgets/TableV2/Inline_editing_3_spec.js (1 hunks)

🧰 Additional context used

📓 Path-based instructions (1)

app/client/cypress/e2e/Regression/ClientSide/Widgets/TableV2/Inline_editing_3_spec.js (1)

Pattern app/client/cypress/**/**.*: Review the following e2e test code written using the Cypress test library. Ensure that:

• Follow best practices for Cypress code and e2e automation.
• Avoid using cy.wait in code.
• Avoid using cy.pause in code.
• Avoid using agHelper.sleep().
• Use locator variables for locators and do not use plain strings.
• Use data-* attributes for selectors.
• Avoid Xpaths, Attributes and CSS path.
• Avoid selectors like .btn.submit or button[type=submit].
• Perform logins via API with LoginFromAPI.
• Perform logout via API with LogOutviaAPI.
• Perform signup via API with SignupFromAPI.
• Avoid using it.only.
• Avoid using after and aftereach in test cases.
• Use multiple assertions for expect statements.
• Avoid using strings for assertions.
• Do not use duplicate filenames even with different paths.
• Avoid using agHelper.Sleep, this.Sleep in any file in code.