chore: upgrade Typescipt to 5.5.4 #35314
Conversation
WalkthroughThe recent updates across the client application's Changes
Sequence Diagram(s)sequenceDiagram
participant Developer
participant TypeScript
participant Application
Developer->>TypeScript: Update version to ^5.5.4
TypeScript-->>Application: New features and improvements
Application->>Developer: Enhanced type-checking and performance
Assessment against linked issues
In summary, the code changes effectively address the objective of upgrading TypeScript to version 5.5, ensuring that the application can leverage improvements and new features that enhance development capabilities. Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Commits
Files that changed from the base of the PR and between d780ecb and c326d2c30920f7a55e12576ed71874bef2be451d.
Files ignored due to path filters (1)
app/client/yarn.lockis excluded by!**/yarn.lock,!**/*.lock
Files selected for processing (4)
- app/client/package.json (1 hunks)
- app/client/packages/ast/package.json (1 hunks)
- app/client/packages/dsl/package.json (1 hunks)
- app/client/packages/rts/package.json (1 hunks)
Files skipped from review due to trivial changes (1)
- app/client/packages/dsl/package.json
Additional comments not posted (3)
app/client/packages/ast/package.json (1)
31-31: Good job! The TypeScript version update is correct.Updating the TypeScript version to
^5.5.4allows for minor and patch updates, which helps keep the project up-to-date with the latest features and bug fixes.app/client/packages/rts/package.json (1)
40-40: Nice work! The TypeScript version update is appropriate.Updating the TypeScript version to
^5.5.4allows for minor and patch updates, ensuring the project benefits from the latest improvements and bug fixes.app/client/package.json (1)
238-238: Well done! The TypeScript version update is correct.Updating the TypeScript version to
^5.5.4allows for minor and patch updates, keeping the project current with the latest features and bug fixes.
znamenskii-ilia
force-pushed
the
chore/upgrade-ts-5_5
branch
from
c326d2c
to
087a3c8
Compare
znamenskii-ilia
changed the title
github-actions
bot
added
skip-changelog
There was a problem hiding this comment.
Actionable comments posted: 0
Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Commits
Files that changed from the base of the PR and between c326d2c30920f7a55e12576ed71874bef2be451d and 087a3c8.
Files ignored due to path filters (1)
app/client/yarn.lockis excluded by!**/yarn.lock,!**/*.lock
Files selected for processing (8)
- app/client/package.json (1 hunks)
- app/client/packages/ast/package.json (1 hunks)
- app/client/packages/design-system/ads/src/Radio/RadioGroup.stories.tsx (1 hunks)
- app/client/packages/design-system/widgets/package.json (1 hunks)
- app/client/packages/dsl/package.json (1 hunks)
- app/client/packages/rts/package.json (1 hunks)
- app/client/packages/storybook/package.json (1 hunks)
- app/client/src/plugins/Linting/utils/groupDifferencesByType.ts (1 hunks)
Files skipped from review due to trivial changes (4)
- app/client/package.json
- app/client/packages/design-system/widgets/package.json
- app/client/packages/rts/package.json
- app/client/packages/storybook/package.json
Files skipped from review as they are similar to previous changes (2)
- app/client/packages/ast/package.json
- app/client/packages/dsl/package.json
Additional comments not posted (3)
app/client/src/plugins/Linting/utils/groupDifferencesByType.ts (2)
1-7: Great job importing the necessary types!The additional imports from the
deep-difflibrary enhance type safety and clarity in the code.
11-13: Excellent update to the return type structure!Using
DiffEdit<unknown, unknown>[],DiffNew<unknown>[], andDiffDeleted<unknown>[]enhances type safety and provides better clarity regarding the nature of the differences being processed.app/client/packages/design-system/ads/src/Radio/RadioGroup.stories.tsx (1)
Line range hint
44-45:
Great job removing the TypeScript error suppression comments!This indicates that the underlying type issues have been resolved, enhancing type safety and reducing the potential for runtime errors.
There was a problem hiding this comment.
Actionable comments posted: 0
Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Commits
Files that changed from the base of the PR and between 087a3c8 and 94ac93e6ce84e08c5c8668d999d3f6b272837855.
Files selected for processing (1)
- app/client/packages/design-system/theming/src/color/tests/LightModeTheme.test.ts (28 hunks)
Additional comments not posted (10)
app/client/packages/design-system/theming/src/color/tests/LightModeTheme.test.ts (10)
42-42: Good job updating the expected RGB value!The updated RGB value for
bgAccentHoverwhen lightness is less than 0.06 looks correct. Make sure to verify the correctness of the RGB value in the implementation.
49-49: Nice update on the RGB value!The updated RGB value for
bgAccentHoverwhen lightness is between 0.06 and 0.14 looks accurate. Ensure the RGB value in the implementation matches this expected value.
56-56: Well done updating the RGB value!The updated RGB value for
bgAccentHoverwhen lightness is between 0.14 and 0.21 and hue is between 120 and 300 seems correct. Verify the implementation to ensure it matches this expected value.
63-63: Good update on the RGB value!The updated RGB value for
bgAccentHoverwhen lightness is between 0.14 and 0.21 and hue is not between 120 and 300 looks accurate. Ensure the RGB value in the implementation matches this expected value.
107-107: Great update on the RGB value!The updated RGB value for
bgAccentActivewhen lightness is less than 0.4 seems correct. Verify the implementation to ensure it matches this expected value.
137-137: Nice work updating the RGB value!The updated RGB value for
bgAccentSubtlewhen seedLightness is greater than 0.93 looks accurate. Ensure the RGB value in the implementation matches this expected value.
192-192: Good job updating the RGB value!The updated RGB value for
bgNeutralwhen lightness is greater than 0.85 seems correct. Verify the implementation to ensure it matches this expected value.
367-367: Great update on the RGB value!The updated RGB value for
bgPositivewhen the seed color is green (hue between 116 and 165) and chroma is greater than 0.11 looks accurate. Ensure the RGB value in the implementation matches this expected value.
435-435: Nice work updating the RGB value!The updated RGB value for
bgNegativewhen the seed color is red (hue between 5 and 49) and chroma is greater than 0.12 seems correct. Verify the implementation to ensure it matches this expected value.
509-509: Good update on the RGB value!The updated RGB value for
bgWarningwhen the seed color is yellow (hue between 60 and 115) and chroma is greater than 0.09 looks accurate. Ensure the RGB value in the implementation matches this expected value.
znamenskii-ilia
force-pushed
the
chore/upgrade-ts-5_5
branch
from
94ac93e
to
8b0aa1a
Compare
There was a problem hiding this comment.
Actionable comments posted: 0
Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Commits
Files that changed from the base of the PR and between 94ac93e6ce84e08c5c8668d999d3f6b272837855 and 8b0aa1a.
Files selected for processing (2)
- app/client/packages/design-system/theming/src/color/tests/DarkModeTheme.test.ts (18 hunks)
- app/client/packages/design-system/theming/src/color/tests/LightModeTheme.test.ts (28 hunks)
Files skipped from review as they are similar to previous changes (1)
- app/client/packages/design-system/theming/src/color/tests/LightModeTheme.test.ts
Additional comments not posted (10)
app/client/packages/design-system/theming/src/color/tests/DarkModeTheme.test.ts (10)
18-18: Verify the correctness of the new expected value forbgAccent.The expected RGB value for
bgAccenthas been updated torgb(0% 20.243% 31.25%). Ensure this change aligns with the intended color logic.
27-27: Verify the correctness of the new expected value forbgAccentHover.The expected RGB value for
bgAccentHoverhas been updated torgb(0% 25.612% 37.776%). Ensure this change aligns with the intended color logic.
78-78: Verify the correctness of the new expected value forbgAccentActive.The expected RGB value for
bgAccentActivehas been updated torgb(0% 18.133% 28.462%). Ensure this change aligns with the intended color logic.
108-108: Verify the correctness of the new expected value forbgAccentSubtle.The expected RGB value for
bgAccentSubtlehas been updated torgb(0% 15.035% 24.345%). Ensure this change aligns with the intended color logic.
115-115: Verify the correctness of the new expected value forbgAccentSubtle.The expected RGB value for
bgAccentSubtlehas been updated torgb(0% 10.07% 17.756%). Ensure this change aligns with the intended color logic.
122-122: Verify the correctness of the new expected value forbgAccentSubtle.The expected RGB value for
bgAccentSubtlehas been updated torgb(0% 15.035% 24.348%). Ensure this change aligns with the intended color logic.
467-467: Verify the correctness of the new expected value forbgNegativeSubtleActive.The expected RGB value for
bgNegativeSubtleActivehas been updated torgb(24.04% 0.52339% 2.9937%). Ensure this change aligns with the intended color logic.
479-479: Verify the correctness of the new expected value forbgWarning.The expected RGB value for
bgWarninghas been updated torgb(85.145% 64.66% 8.0285%). Ensure this change aligns with the intended color logic.
484-484: Verify the correctness of the new expected value forbgWarning.The expected RGB value for
bgWarninghas been updated torgb(85.145% 64.66% 8.0285%). Ensure this change aligns with the intended color logic.
489-489: Verify the correctness of the new expected value forbgWarning.The expected RGB value for
bgWarninghas been updated torgb(85.145% 64.66% 8.0285%). Ensure this change aligns with the intended color logic.
znamenskii-ilia
added
ok-to-test
Description
Fixes #35296
Automation
/ok-to-test tags="@tag.All"
🔍 Cypress test results
Tip
🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/10182307436
Commit: 8b0aa1a
Cypress dashboard.
Tags:
@tag.AllSpec:
Wed, 31 Jul 2024 15:48:59 UTC
Communication
Should the DevRel and Marketing teams inform users about this change?
Summary by CodeRabbit
Summary by CodeRabbit
New Features
colorjs.iodependency in design system packages to enhance functionality.Bug Fixes
LightModeThemeandDarkModeThemeto improve visual accuracy.Chores
colorjs.io.