test: switch branch spec ce #35312

NandanAnantharamu · 2024-07-31T09:53:13Z

Enabled Test
Replaced some validations with should with aghelper assertions

EE: https://github.com/appsmithorg/appsmith-ee/pull/4755

/ok-to-test tags="@tag.Sanity"

Summary by CodeRabbit

Bug Fixes
- Enhanced testing for Git synchronization by refining branch name handling in input fields, leading to improved reliability.
Chores
- Updated the Cypress limited tests to focus on the SwitchBranches_spec.js, changing the test execution target.
- Removed unnecessary wait command to streamline test execution.

Tip

🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/10181073301
Commit: 41db4eb
Cypress dashboard.
Tags: @tag.Sanity
Spec:

Wed, 31 Jul 2024 13:48:05 UTC

coderabbitai · 2024-07-31T09:53:21Z

Walkthrough

The recent changes enhance the testing framework for Git synchronization in the Cypress suite by adopting a helper function for input assertions, which promotes modularity and maintainability. Additionally, the focus of the limited tests has shifted from one specification to another, indicating a refined testing strategy. These updates aim to improve code clarity and execution efficiency, reflecting a commitment to best practices in testing.

Changes

Files	Change Summary
`app/client/cypress/e2e/Regression/ClientSide/Git/GitSync/SwitchBranches_spec.js`	Replaced direct value assertions with `agHelper.AssertAttribute` for improved readability and maintainability; removed explicit wait command to streamline execution.
`app/client/cypress/limited-tests.txt`	Updated the test specification entry from `Fork_Template_spec.js` to `SwitchBranches_spec.js`, changing the testing focus.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant Cypress
    participant agHelper

    User->>Cypress: Initiate Git Sync Test
    Cypress->>agHelper: Assert Attribute for Branch Name
    agHelper-->>Cypress: Return Assertion Result
    Cypress->>User: Test Execution Complete

Poem

In the realm of code so bright,
Assertions dance, a cleaner sight.
Helpers rise to share the load,
Streamlining tests on this fine road.
Branches switch with graceful flair,
Efficiency blooms, a breath of fresh air! 🌿✨

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai generate interesting stats about this repository and render them as a table.
- @coderabbitai show all the console.log statements in this repository.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

NandanAnantharamu · 2024-07-31T09:53:43Z

/ci-test-limit

github-actions · 2024-07-31T09:54:16Z

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/10178031360.
Cypress dashboard
PR: #35312.

coderabbitai

Actionable comments posted: 0

Review details

Configuration used: .coderabbit.yaml
Review profile: CHILL

Commits

Files that changed from the base of the PR and between d780ecb and e812a9bc9b9ad10fb5fcf4e53ff8fc4faf58ecce.

Files ignored due to path filters (1)

app/client/cypress/downloads/kiwi.svg is excluded by !**/*.svg

Files selected for processing (2)

app/client/cypress/e2e/Regression/ClientSide/Git/GitSync/SwitchBranches_spec.js (2 hunks)
app/client/cypress/limited-tests.txt (1 hunks)

Files skipped from review due to trivial changes (1)

app/client/cypress/limited-tests.txt

Additional context used

Path-based instructions (1)

app/client/cypress/e2e/Regression/ClientSide/Git/GitSync/SwitchBranches_spec.js (1)

Pattern app/client/cypress/**/**.*: Review the following e2e test code written using the Cypress test library. Ensure that:

Follow best practices for Cypress code and e2e automation.

Avoid using cy.wait in code.

Avoid using cy.pause in code.

Avoid using agHelper.sleep().

Use locator variables for locators and do not use plain strings.

Use data-* attributes for selectors.

Avoid Xpaths, Attributes and CSS path.

Avoid selectors like .btn.submit or button[type=submit].

Perform logins via API with LoginFromAPI.

Perform logout via API with LogOutviaAPI.

Perform signup via API with SignupFromAPI.

Avoid using it.only.

Avoid using after and aftereach in test cases.

Use multiple assertions for expect statements.

Avoid using strings for assertions.

Do not use duplicate filenames even with different paths.

Avoid using agHelper.Sleep, this.Sleep in any file in code.

Additional comments not posted (2)

app/client/cypress/e2e/Regression/ClientSide/Git/GitSync/SwitchBranches_spec.js (2)

43-45: Good use of agHelper.AssertAttribute for assertions.

The change to use agHelper.AssertAttribute improves code readability and maintainability.

52-54: Good use of agHelper.AssertAttribute for assertions.

The change to use agHelper.AssertAttribute improves code readability and maintainability.

coderabbitai

Actionable comments posted: 0

Review details

Configuration used: .coderabbit.yaml
Review profile: CHILL

Commits

Files that changed from the base of the PR and between e812a9bc9b9ad10fb5fcf4e53ff8fc4faf58ecce and 6a06e22.

Files selected for processing (2)

app/client/cypress/e2e/Regression/ClientSide/Git/GitSync/SwitchBranches_spec.js (2 hunks)
app/client/cypress/limited-tests.txt (1 hunks)

Files skipped from review due to trivial changes (1)

app/client/cypress/limited-tests.txt

Files skipped from review as they are similar to previous changes (1)

app/client/cypress/e2e/Regression/ClientSide/Git/GitSync/SwitchBranches_spec.js

github-actions · 2024-07-31T10:19:07Z

Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/10178031360.
Cypress dashboard url: Click here!
All cypress tests have passed 🎉🎉🎉

NandanAnantharamu · 2024-07-31T10:35:34Z