Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Task]: Handle updating the name of the action #36498

Closed
2 tasks
Tracked by #34663
ankitakinger opened this issue Sep 24, 2024 · 0 comments · Fixed by #36560
Closed
2 tasks
Tracked by #34663

[Task]: Handle updating the name of the action #36498

ankitakinger opened this issue Sep 24, 2024 · 0 comments · Fixed by #36560
Assignees
@ankitakinger
Labels
IDE Pod Issues that new developers face while exploring the IDE IDE Product Issues related to the IDE Product Task A simple Todo
Milestone
Action Redesign :...

Comments

@ankitakinger
Copy link
Contributor

SubTasks

  • Same for workflows
  • The one for app is a default option inside NameEditorComponent
@ankitakinger ankitakinger added IDE Product Issues related to the IDE Product Task A simple Todo IDE Pod Issues that new developers face while exploring the IDE labels Sep 24, 2024
@ankitakinger ankitakinger self-assigned this Sep 24, 2024
This was referenced Sep 24, 2024
Open
Merged
ankitakinger added a commit that referenced this issue Sep 27, 2024
@ankitakinger
chore: Handling the updation of action name in the plugin action tool…
5995e42 
…bar (#36560)

## Description

Handling the updation of action name in the plugin action toolbar in the
new modularised flow.

Fixes [#36498](#36498)

## Automation

/ok-to-test tags="@tag.All"

### 🔍 Cypress test results
<!-- This is an auto-generated comment: Cypress test results  -->
> [!TIP]
> 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
> Workflow run:
<https://github.com/appsmithorg/appsmith/actions/runs/11071023786>
> Commit: 73647e5
> <a
href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=11071023786&attempt=1"
target="_blank">Cypress dashboard</a>.
> Tags: `@tag.All`
> Spec:
> <hr>Fri, 27 Sep 2024 14:15:24 UTC
<!-- end of auto-generated comment: Cypress test results  -->


## Communication
Should the DevRel and Marketing teams inform users about this change?
- [ ] Yes
- [ ] No


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit

- **New Features**
- Introduced a new component for editing plugin action names, enhancing
user experience in managing plugin actions.
- Added optional icon size property to the editable text component for
improved customization.
- Enhanced the `CommonEditorForm` and `QueryEditorHeader` components to
display plugin-specific information and saving status.

- **Bug Fixes**
- Streamlined action dispatching logic, improving reliability in saving
actions.

- **Documentation**
- Updated interfaces and prop types for better clarity and type safety
in the codebase.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->
@ankitakinger ankitakinger reopened this Sep 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ankitakinger ankitakinger

Labels
IDE Pod Issues that new developers face while exploring the IDE IDE Product Issues related to the IDE Product Task A simple Todo
Projects
None yet
Milestone
Action Redesign :: Modularisation
Development

Successfully merging a pull request may close this issue.

chore: Handling the updation of action name in the plugin action toolbar appsmithorg/appsmith
1 participant
@ankitakinger