Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Task]: Add "use prepared statement" warning message in response pane #36326

Closed
Tracked by #34323
albinAppsmith opened this issue Sep 16, 2024 · 0 comments · Fixed by #36407
Closed
Tracked by #34323

[Task]: Add "use prepared statement" warning message in response pane #36326

albinAppsmith opened this issue Sep 16, 2024 · 0 comments · Fixed by #36407
Assignees
@albinAppsmith
Labels
IDE Navigation Issues/feature requests related to IDE navigation, and context switching IDE Pod Issues that new developers face while exploring the IDE IDE Product Issues related to the IDE Product Task A simple Todo
Milestone
Action Redesign :...

Comments

@albinAppsmith
Copy link
Collaborator

albinAppsmith commented Sep 16, 2024 •
edited
Loading

design: https://app.zeplin.io/project/6683c698d2210f2b0697d978/screen/66951e174073dc249b335471
@albinAppsmith albinAppsmith mentioned this issue Sep 16, 2024
Closed
6 tasks
@Nikhil-Nandagopal Nikhil-Nandagopal added the Task A simple Todo label Sep 16, 2024
@albinAppsmith albinAppsmith self-assigned this Sep 16, 2024
@albinAppsmith albinAppsmith added the IDE Navigation Issues/feature requests related to IDE navigation, and context switching label Sep 16, 2024
@github-actions github-actions bot added IDE Product Issues related to the IDE Product IDE Pod Issues that new developers face while exploring the IDE labels Sep 16, 2024
@albinAppsmith albinAppsmith mentioned this issue Sep 19, 2024
Merged
2 tasks
Shivam-z pushed a commit to Shivam-z/appsmith that referenced this issue Sep 26, 2024
@albinAppsmith @Shivam-z
feat: Added warning message in response pane while prepared statement…
f285638 
… is on (appsmithorg#36407)

## Description

Added warning message in response pane to show that use prepared
statement is turned on. This will be showing up only if there is an
error.

Fixes appsmithorg#36326 

## Automation

/ok-to-test tags="@tag.Sanity, @tag.Datasource"

### 🔍 Cypress test results
<!-- This is an auto-generated comment: Cypress test results  -->
> [!TIP]
> 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
> Workflow run:
<https://github.com/appsmithorg/appsmith/actions/runs/10987691166>
> Commit: debc9f3
> <a
href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=10987691166&attempt=1"
target="_blank">Cypress dashboard</a>.
> Tags: `@tag.Sanity, @tag.Datasource`
> Spec:
> <hr>Mon, 23 Sep 2024 05:25:23 UTC
<!-- end of auto-generated comment: Cypress test results  -->


## Communication
Should the DevRel and Marketing teams inform users about this change?
- [ ] Yes
- [ ] No


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit

- **New Features**
- Introduced a warning message for users regarding prepared statements
that may cause query errors.
- Added a mechanism to navigate users to the settings page for resolving
issues related to prepared statements.
- Enhanced the Query Response Tab with contextual warnings and improved
user guidance.

- **Bug Fixes**
- Improved error handling related to prepared statements in the query
response.

- **Tests**
- Added comprehensive unit tests for the Query Response Tab to ensure
correct behavior of the prepared statement warning under various
conditions.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@albinAppsmith albinAppsmith

Labels
IDE Navigation Issues/feature requests related to IDE navigation, and context switching IDE Pod Issues that new developers face while exploring the IDE IDE Product Issues related to the IDE Product Task A simple Todo
Projects
None yet
Milestone
Action Redesign :: UQI Configuration ...
Development

Successfully merging a pull request may close this issue.

feat: Added warning message in response pane while prepared statement is on appsmithorg/appsmith
2 participants
@Nikhil-Nandagopal @albinAppsmith