Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Task] Create Plugin Action Editor component #36153

Closed
Tracked by #34663
, #34324
...
hetunandu opened this issue Sep 6, 2024 · 0 comments · Fixed by #36651
Closed
Tracked by #34663
, #34324
...

[Task] Create Plugin Action Editor component #36153

hetunandu opened this issue Sep 6, 2024 · 0 comments · Fixed by #36651
Assignees
@hetunandu
Labels
IDE Pod Issues that new developers face while exploring the IDE IDE Product Issues related to the IDE Product Task A simple Todo
Milestone
Action Redesign :...

Comments

@hetunandu
Copy link
Member

hetunandu commented Sep 6, 2024 •
edited
Loading

A new Plugin Action Editor component that will combine ApiEditor and QueryEditor components. It will implement that wrapping logic duplicated in the 2 editors and configure the Plugin Action context. It will be composable to allow differences in IDEs. It should not include implementation of the Toolbar, form or the response pane
@Nikhil-Nandagopal Nikhil-Nandagopal added the Task A simple Todo label Sep 6, 2024
@github-actions github-actions bot mentioned this issue Sep 6, 2024
Closed
4 tasks
@hetunandu hetunandu self-assigned this Sep 6, 2024
@hetunandu hetunandu added the IDE Product Issues related to the IDE Product label Sep 6, 2024
@github-actions github-actions bot added the IDE Pod Issues that new developers face while exploring the IDE label Sep 6, 2024
@coderabbitai coderabbitai bot mentioned this issue Sep 9, 2024
Merged
2 tasks
@hetunandu hetunandu mentioned this issue Sep 9, 2024
Closed
@coderabbitai coderabbitai bot mentioned this issue Sep 10, 2024
Merged
2 tasks
@ankitakinger ankitakinger mentioned this issue Sep 20, 2024
Open
@hetunandu hetunandu mentioned this issue Oct 2, 2024
Merged
2 tasks
hetunandu added a commit that referenced this issue Oct 8, 2024
@hetunandu
chore: [Plugin Action Editor] Combine Plugin Editor UI state (#36651)
8463d02 
## Description

Removes the parallel apiPaneReducer and queryPaneReducer and combines it
into pluginActionEditor


Fixes #36153

## Automation

/ok-to-test tags="@tag.All"

### 🔍 Cypress test results
<!-- This is an auto-generated comment: Cypress test results  -->
> [!TIP]
> 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
> Workflow run:
<https://github.com/appsmithorg/appsmith/actions/runs/11231694032>
> Commit: 3a204e2
> <a
href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=11231694032&attempt=2"
target="_blank">Cypress dashboard</a>.
> Tags: `@tag.All`
> Spec:
> <hr>Tue, 08 Oct 2024 10:15:30 UTC
<!-- end of auto-generated comment: Cypress test results  -->


## Communication
Should the DevRel and Marketing teams inform users about this change?
- [ ] Yes
- [x] No


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit

## Release Notes

- **New Features**
- Introduced a new constant `POST_BODY_FORM_DATA_KEY` for improved data
handling.
- Added several action creators and selectors for enhanced management of
the plugin action editor's state.
- Implemented state management for the plugin action editor's debugger.
- Added the ability to execute commands related to plugins in the
`CodeEditor` component.
- Introduced a new enumeration `DEBUGGER_TAB_KEYS` for better
organization of debugger tabs.

- **Improvements**
- Refactored import statements for better organization and reduced
complexity.
- Enhanced the `PluginActionResponse` component to focus on plugin
action state management.
- Updated the tab management logic in various components to reflect the
new plugin action state.
- Improved state management in the `QueryEditor` and `APIEditor`
components to accurately represent action processing states.
- Added error handling in the `ActionSettings` component for missing
configuration.

- **Bug Fixes**
- Updated logic in hooks to ensure proper state management for plugin
actions.
- Adjusted navigation and tab selection methods to align with the new
plugin action state management.
- Corrected test selectors for error tabs in Cypress tests to ensure
accurate UI interactions.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hetunandu hetunandu

Labels
IDE Pod Issues that new developers face while exploring the IDE IDE Product Issues related to the IDE Product Task A simple Todo
Projects
None yet
Milestone
Action Redesign :: Modularisation
Development

Successfully merging a pull request may close this issue.

chore: [Plugin Action Editor] Combine Plugin Editor UI state appsmithorg/appsmith
2 participants
@Nikhil-Nandagopal @hetunandu