Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Task]: Create Plugin Action context #36152

Closed
Tracked by #34663
, #34324
...
hetunandu opened this issue Sep 6, 2024 · 0 comments · Fixed by #36187
Closed
Tracked by #34663
, #34324
...

[Task]: Create Plugin Action context #36152

hetunandu opened this issue Sep 6, 2024 · 0 comments · Fixed by #36187
Assignees
@hetunandu
Labels
IDE Pod Issues that new developers face while exploring the IDE IDE Product Issues related to the IDE Product Task A simple Todo
Milestone
Action Redesign :...

Comments

@hetunandu
Copy link
Member

hetunandu commented Sep 6, 2024 •
edited
Loading

We will create a new react context called Plugin Action. This will be used to pass down the Plugin Action and its other details that would be needed to render the Plugin Action Editor component. This will be a common component between Apis and Queries. This context can be used inside all IDEs
@hetunandu hetunandu mentioned this issue Sep 6, 2024
Closed
4 tasks
@Nikhil-Nandagopal Nikhil-Nandagopal added the Task A simple Todo label Sep 6, 2024
@hetunandu hetunandu changed the title Create Plugin Action context [Task]: Create Plugin Action context Sep 6, 2024
@hetunandu hetunandu self-assigned this Sep 6, 2024
@hetunandu hetunandu added the IDE Product Issues related to the IDE Product label Sep 6, 2024
@github-actions github-actions bot added the IDE Pod Issues that new developers face while exploring the IDE label Sep 6, 2024
@hetunandu hetunandu mentioned this issue Sep 9, 2024
Merged
2 tasks
@coderabbitai coderabbitai bot mentioned this issue Sep 10, 2024
Merged
2 tasks
@ankitakinger ankitakinger mentioned this issue Sep 20, 2024
Open
Shivam-z pushed a commit to Shivam-z/appsmith that referenced this issue Sep 26, 2024
@hetunandu @Shivam-z
chore: Plugin Action Editor Context (appsmithorg#36187)
f390513 
## Description

- Introduce the PluginActionEditor module structure
- Add basic handling and states in the PluginActionContext
- Update AppIDE to use the new Editor when the feature flag is active.
This will later be updated and the component will be used from the route
level itself


Fixes appsmithorg#36152

## Automation

/ok-to-test tags="@tag.Datasource"

### 🔍 Cypress test results
<!-- This is an auto-generated comment: Cypress test results  -->
> [!TIP]
> 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
> Workflow run:
<https://github.com/appsmithorg/appsmith/actions/runs/10805408539>
> Commit: 1b8259b
> <a
href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=10805408539&attempt=1"
target="_blank">Cypress dashboard</a>.
> Tags: `@tag.Datasource`
> Spec:
> <hr>Wed, 11 Sep 2024 05:53:02 UTC
<!-- end of auto-generated comment: Cypress test results  -->


## Communication
Should the DevRel and Marketing teams inform users about this change?
- [ ] Yes
- [x] No


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit


- **New Features**
- Introduced a `PluginActionEditor` component for managing plugin
actions.
- Added `PluginActionContext` for improved state management of plugin
actions.
- Implemented feature flag checks to conditionally render the redesigned
action editor interface in both the `ApiEditorWrapper` and `QueryEditor`
components.

- **Documentation**
- Added centralized export files for easier access to new components and
context providers.

- **Bug Fixes**
- Enhanced error handling for missing plugin settings and configurations
in the `PluginActionEditor`.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hetunandu hetunandu

Labels
IDE Pod Issues that new developers face while exploring the IDE IDE Product Issues related to the IDE Product Task A simple Todo
Projects
None yet
Milestone
Action Redesign :: Modularisation
Development

Successfully merging a pull request may close this issue.

chore: Plugin Action Editor Context appsmithorg/appsmith
2 participants
@Nikhil-Nandagopal @hetunandu