Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TASK]: Add metrics to newRelic for JSObject update collection flow #36049

Closed
rishabhrathod01 opened this issue Sep 2, 2024 · 0 comments · Fixed by #35947
Closed

[TASK]: Add metrics to newRelic for JSObject update collection flow #36049

rishabhrathod01 opened this issue Sep 2, 2024 · 0 comments · Fixed by #35947
Assignees
@rishabhrathod01
Labels
Javascript Product Issues related to users writing javascript in appsmith JS Objects Issues related to JS Objects Query & JS Pod Issues related to the query & JS Pod

Comments

@rishabhrathod01
Copy link
Contributor

rishabhrathod01 commented Sep 2, 2024 •
edited
Loading

No description provided.

@rishabhrathod01 rishabhrathod01 mentioned this issue Sep 2, 2024
Open
@rishabhrathod01 rishabhrathod01 changed the title Try to make the multiple updateLayout method execution run in parallel [SUBTASK]: Optimise the JSObject collection update call - 1. Try to make the multiple updateLayout method execution run in parallel Sep 2, 2024
@rishabhrathod01 rishabhrathod01 changed the title [SUBTASK]: Optimise the JSObject collection update call - 1. Try to make the multiple updateLayout method execution run in parallel [SUBTASK]: 1. Try to make the multiple updateLayout method execution run in parallel Sep 2, 2024
@rishabhrathod01 rishabhrathod01 added the Query & JS Pod Issues related to the query & JS Pod label Sep 2, 2024
@github-actions github-actions bot removed the Query & JS Pod Issues related to the query & JS Pod label Sep 2, 2024
@rohan-arthur rohan-arthur added the Javascript Product Issues related to users writing javascript in appsmith label Sep 2, 2024
@github-actions github-actions bot removed the Javascript Product Issues related to users writing javascript in appsmith label Sep 2, 2024
@rishabhrathod01 rishabhrathod01 added the JS Objects Issues related to JS Objects label Sep 3, 2024
@github-actions github-actions bot added Javascript Product Issues related to users writing javascript in appsmith Query & JS Pod Issues related to the query & JS Pod labels Sep 3, 2024
@rishabhrathod01 rishabhrathod01 changed the title [SUBTASK]: 1. Try to make the multiple updateLayout method execution run in parallel [TASK]: Make the multiple updateLayout method execution run in parallel Sep 3, 2024
@rishabhrathod01 rishabhrathod01 mentioned this issue Sep 4, 2024
Merged
2 tasks
@rishabhrathod01 rishabhrathod01 changed the title [TASK]: Make the multiple updateLayout method execution run in parallel [TASK]: Add metrics to newRelic for JSObject update collection flow Sep 4, 2024
@rishabhrathod01 rishabhrathod01 self-assigned this Sep 5, 2024
rishabhrathod01 added a commit that referenced this issue Sep 5, 2024
@rishabhrathod01
chore: Add metrics to newRelic for update JSobject Collection (#35947)
b447b0f 
## Description

- Add newRelic spans to track performance of process involved in update
JSObject collection

Fixes #36049 

## Automation

/test js

### 🔍 Cypress test results
<!-- This is an auto-generated comment: Cypress test results  -->
> [!TIP]
> 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
> Workflow run:
<https://github.com/appsmithorg/appsmith/actions/runs/10704346206>
> Commit: 5bf63bb
> <a
href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=10704346206&attempt=1"
target="_blank">Cypress dashboard</a>.
> Tags: `@tag.JS`
> Spec:
> <hr>Wed, 04 Sep 2024 15:29:57 UTC
<!-- end of auto-generated comment: Cypress test results  -->


## Communication
Should the DevRel and Marketing teams inform users about this change?
- [ ] Yes
- [x] No


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit

## Summary by CodeRabbit

- **New Features**
- Introduced enhanced observability for action collections and layout
updates, allowing better tracking and monitoring of actions within the
application.
- Added new constants related to action collections and layout updates
for improved functionality and clarity.

- **Bug Fixes**
- Improved the reliability of action collection retrieval and layout
updates through enhanced observability features.

- **Tests**
- Updated tests to incorporate observability metrics, ensuring better
monitoring of actions during testing.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->
Shivam-z pushed a commit to Shivam-z/appsmith that referenced this issue Sep 26, 2024
@rishabhrathod01 @Shivam-z
chore: Add metrics to newRelic for update JSobject Collection (appsmi…
75ec959 
…thorg#35947)

## Description

- Add newRelic spans to track performance of process involved in update
JSObject collection

Fixes appsmithorg#36049 

## Automation

/test js

### 🔍 Cypress test results
<!-- This is an auto-generated comment: Cypress test results  -->
> [!TIP]
> 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
> Workflow run:
<https://github.com/appsmithorg/appsmith/actions/runs/10704346206>
> Commit: 5bf63bb
> <a
href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=10704346206&attempt=1"
target="_blank">Cypress dashboard</a>.
> Tags: `@tag.JS`
> Spec:
> <hr>Wed, 04 Sep 2024 15:29:57 UTC
<!-- end of auto-generated comment: Cypress test results  -->


## Communication
Should the DevRel and Marketing teams inform users about this change?
- [ ] Yes
- [x] No


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit

## Summary by CodeRabbit

- **New Features**
- Introduced enhanced observability for action collections and layout
updates, allowing better tracking and monitoring of actions within the
application.
- Added new constants related to action collections and layout updates
for improved functionality and clarity.

- **Bug Fixes**
- Improved the reliability of action collection retrieval and layout
updates through enhanced observability features.

- **Tests**
- Updated tests to incorporate observability metrics, ensuring better
monitoring of actions during testing.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rishabhrathod01 rishabhrathod01

Labels
Javascript Product Issues related to users writing javascript in appsmith JS Objects Issues related to JS Objects Query & JS Pod Issues related to the query & JS Pod
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: Add metrics to newRelic for update JSobject Collection appsmithorg/appsmith
2 participants
@rishabhrathod01 @rohan-arthur