Skip to content

Commit

Permalink
fix: Fix shareapp case due to load issue (#36627)
Browse files Browse the repository at this point in the history
## Description
Fixes #`36626`  

Issue: Script was clicking on share button without full page load.
Solution: Waited for page load with api.

EE PR: appsmithorg/appsmith-ee#5285

## Automation

/ok-to-test tags="@tag.Sanity"

### 🔍 Cypress test results
<!-- This is an auto-generated comment: Cypress test results  -->
> [!TIP]
> 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
> Workflow run:
<https://github.com/appsmithorg/appsmith/actions/runs/11174778224>
> Commit: 80be7e1
> <a
href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=11174778224&attempt=2"
target="_blank">Cypress dashboard</a>.
> Tags: `@tag.Sanity`
> Spec:
> <hr>Fri, 04 Oct 2024 07:01:59 UTC
<!-- end of auto-generated comment: Cypress test results  -->


## Communication
Should the DevRel and Marketing teams inform users about this change?
- [ ] Yes
- [x] No


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit

- **New Features**
- Enhanced test coverage for workspace sharing and public access
functionalities.
- Added assertions to validate visibility of the Git sync bottom bar
during application editing.
  
- **Bug Fixes**
- Updated specification for limited tests to point to the correct test
file, ensuring accurate execution of tests.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->
  • Loading branch information
sagar-qa007 authored Oct 4, 2024
1 parent d1e788b commit cf0bfa5
Showing 1 changed file with 1 addition and 0 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -113,6 +113,7 @@ describe(
agHelper.AssertElementExist(homePage._appEditIcon);
agHelper.GetNClick(homePage._appEditIcon, 0, true);
agHelper.AssertElementAbsence(locators._loading);
assertHelper.AssertNetworkStatus("@getConsolidatedData", 200, true);
agHelper.GetNClick(inviteModal.locators._shareButton, 0, true);
agHelper.GetNClick(homePage._sharePublicToggle, 0, true);
agHelper.GetNClick(locators._dialogCloseButton, 0, true);
Expand Down

0 comments on commit cf0bfa5

Please sign in to comment.