Skip to content

Commit

Permalink
chore: Updating the settings icon throughout the product (#37330)
Browse files Browse the repository at this point in the history
## Description

Updating the settings icon throughout the product to use the below icon:

https://www.figma.com/design/8L9BXMzNTKboGWlHpdXyYP/Appsmith-IDE?node-id=33-3546&t=qpptzxhkWatrFIn1-4


Fixes [#37248](#37248)

## Automation

/ok-to-test tags="@tag.Sanity"

### 🔍 Cypress test results
<!-- This is an auto-generated comment: Cypress test results  -->
> [!TIP]
> 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
> Workflow run:
<https://github.com/appsmithorg/appsmith/actions/runs/11796204902>
> Commit: 0e57343
> <a
href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=11796204902&attempt=2"
target="_blank">Cypress dashboard</a>.
> Tags: `@tag.Sanity`
> Spec:
> <hr>Tue, 12 Nov 2024 12:12:33 UTC
<!-- end of auto-generated comment: Cypress test results  -->


## Communication
Should the DevRel and Marketing teams inform users about this change?
- [ ] Yes
- [ ] No


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit

- **New Features**
- Updated icons for various settings-related components from
"settings-2-line" to "settings-v3" to enhance visual representation.

- **Bug Fixes**
- Improved handling of frame ancestor settings in the AdminSettings
configuration, ensuring better management of stored values.

- **Documentation**
	- No changes to the documentation were made in this release. 

- **Chores**
- Updated multiple components to reflect the new icon, maintaining
overall functionality without introducing new logic.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->
  • Loading branch information
ankitakinger authored Nov 12, 2024
1 parent 5af1bbe commit 91cf54b
Show file tree
Hide file tree
Showing 13 changed files with 16 additions and 34 deletions.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Original file line number Diff line number Diff line change
Expand Up @@ -7311,7 +7311,7 @@
"controlType": "OPEN_CONFIG_PANEL",
"buttonConfig": {
"label": "Configure",
"icon": "settings-2-line"
"icon": "settings-v3"
},
"label": "Configure menu items",
"isBindProperty": false,
Expand Down Expand Up @@ -47874,7 +47874,7 @@
"controlType": "OPEN_CONFIG_PANEL",
"buttonConfig": {
"label": "Configure",
"icon": "settings-2-line"
"icon": "settings-v3"
},
"label": "Configure menu items",
"isBindProperty": false,
Expand Down
2 changes: 1 addition & 1 deletion app/client/src/IDE/Components/ToolbarSettingsPopover.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ export const ToolbarSettingsPopover = (props: Props) => {
<ToggleButton
data-testid={props.dataTestId}
disabled={props.disabled}
icon="settings-2-line"
icon="settings-v3"
isSelected={isOpen}
onClick={handleButtonClick}
size="md"
Expand Down
2 changes: 1 addition & 1 deletion app/client/src/ce/pages/AdminSettings/config/general.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -181,7 +181,7 @@ export const APPSMITH_ALLOWED_FRAME_ANCESTORS_SETTING: Setting = {
};

export const config: AdminConfigType = {
icon: "settings-2-line",
icon: "settings-v3",
type: SettingCategories.GENERAL,
categoryType: CategoryType.GENERAL,
controlType: SettingTypes.GROUP,
Expand Down
2 changes: 1 addition & 1 deletion app/client/src/ce/pages/Applications/WorkspaceMenu.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -144,7 +144,7 @@ function WorkspaceMenu({
})
}
>
<Icon name="settings-2-line" size="md" />
<Icon name="settings-v3" size="md" />
Settings
</CustomMenuItem>
</>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -205,7 +205,7 @@ export function DraggableListCard(props: RenderComponentProps) {
}}
onFocus={(e) => e.stopPropagation()}
size="sm"
startIcon="settings-2-line"
startIcon="settings-v3"
/>
)}
{showDelete && (
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,7 @@ export const propertyPaneContentConfig = [
controlType: "OPEN_CONFIG_PANEL",
buttonConfig: {
label: "Configure",
icon: "settings-2-line",
icon: "settings-v3",
},
label: "Configure menu items",
isBindProperty: false,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -126,7 +126,7 @@ function AppSettings() {
const SectionHeadersConfig: SectionHeaderProps[] = [
{
id: "t--general-settings-header",
icon: "settings-2-line",
icon: "settings-v3",
isSelected: selectedTab.type === AppSettingsTabs.General,
name: createMessage(GENERAL_SETTINGS_SECTION_HEADER),
onClick: () => {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -215,7 +215,7 @@ const getQuickActionButtons = ({
},
{
className: "t--bottom-git-settings",
icon: "settings-2-line",
icon: "settings-v3",
onClick: settings,
tooltipText: createMessage(GIT_SETTINGS),
},
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ const allStaticChangeDefs: Record<
[StaticChangeKind.SETTINGS]: (status: GitStatusData) => ({
condition: status.modified.includes("application.json"),
message: "Application settings modified",
iconName: "settings-2-line",
iconName: "settings-v3",
}),
[StaticChangeKind.THEME]: (status: GitStatusData) => ({
condition: status.modified.includes("theme.json"),
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,7 @@ const HomepageHeaderAction = ({
});
}}
size="md"
startIcon="settings-control"
startIcon="settings-v3"
/>
</Tooltip>
)}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,7 @@ export default [
controlType: "OPEN_CONFIG_PANEL",
buttonConfig: {
label: "Configure",
icon: "settings-2-line",
icon: "settings-v3",
},
label: "Configure menu items",
isBindProperty: false,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -181,7 +181,7 @@ export default {
controlType: "OPEN_CONFIG_PANEL",
buttonConfig: {
label: "Configure",
icon: "settings-2-line",
icon: "settings-v3",
},
label: "Configure menu items",
isBindProperty: false,
Expand Down

0 comments on commit 91cf54b

Please sign in to comment.