-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add fs module support #777
Conversation
I have looked into the issue where the Prisma test applications fail to boot when the FS instrumentation is added. TL;DR: We gotta wait for a release containing the changes in this PR to be published (should be included in the next release) and update the The core of the issue is that the Prisma client calls Since This is consistent with the error message we see:
Prisma is trying to set the clientVersion property on the error object it received, but the error object isn't an object, but a boolean Now, the reason why this bug only happens for the instrumented version of the function is that the original Or rather, it doesn't yet, as there's a merged PR implementing this custom behaviour for the instrumented version of the function. This should fix our problems; we just need to wait for a release including the change. I have not been able to verify the actual fix directly (npm's "install from GitHub" does not play well with monorepos) but I have confirmed that manually excluding |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look good, but let's not merge this until there's an updated version of the @opentelemetry/instrumentation-fs
library, or else it will break for Prisma users.
All fs module usage is now automatically instrumented. Tests are in the express-redis sample application. Automatic instrumentation is manually suppresed in the test span processor because it uses the fs module to handle the spans.json file. It is done using the `supressTracing` helper provided by OpenTelemetry core library.
4413abb
to
cee020f
Compare
All fs module usage is now automatically instrumented.
Tests are in the express-redis sample application.
Automatic instrumentation is manually suppresed in the test span processor because it uses the fs module to handle the spans.json file. It is done using the
supressTracing
helper provided by OpenTelemetry core library.Part of #763.