-
Notifications
You must be signed in to change notification settings - Fork 9
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Pass span to params helper in Koa hook
When the Koa instrumentation request hook is executed, the current active span is the span from the _previous_ layer. This means that, for the router layer, the active span is the last middleware in the middleware chain. While this is fine functionally, it makes the behaviour of the hook hard to reason about. This change makes it so that the params are set in the span passed to the hook, instead of in the active span. The integration tests are also amended to check for the params in the router child span.
- Loading branch information
Showing
2 changed files
with
6 additions
and
5 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters