-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support vanilla Hawthorn through Open edX plugins #84
Conversation
dude, that's fantastic news. thank you!!!! :D |
Thanks for passing by @lpm0073! I'm soo guilty of not making this pull request earlier! |
Codecov Report
@@ Coverage Diff @@
## hawthorn-upgrade #84 +/- ##
===================================================
- Coverage 89.22% 88.1% -1.12%
===================================================
Files 66 65 -1
Lines 3600 3623 +23
===================================================
- Hits 3212 3192 -20
- Misses 388 431 +43
Continue to review full report at Codecov.
|
1c1a6a4
to
b41f7af
Compare
@johnbaldwin I've rebased the branch over One thing I've done, no Ficus support anymore here! |
@johnbaldwin any idea how to convince CodeCov that it's ok? |
@OmarIthawi I'll look into this today |
@OmarIthawi It appears the issue is that code coverage dropped too low. We need test coverage for figures.apps. I need to look into how to unit test apps. I will add more test coverage for figures.sites and figures.permissions since those are pretty weak |
Thanks @johnbaldwin! I'm done here, as far as I know. Please merge if it looks good to you. |
In multisite mode, figures.sites requires organizations to be linked with sites and courses and courses to be linked with organizations. This commit creates those associations if multisite mode enabled ane/or Appsembler's fork of edx-organizations is used
Added assertions where user sets should have the same number of records. This is failing because additional users are apparently being added to the test database between the setup call and the test method
Overview
To make the installation steps for Hawthorn+:
$ pip install figures=x.y.z
/edx/bin/edxapp-migrate-lms
🔥Screenshot
Too Long; Don't Read
So, I made a lot of noise about it but finally got the time to actually get it done.
This pull request uses the Open edX plugins architecture that is supported since Hawthorn.
I dare to say that this also supports Ironwood, but it's early to say without really testing it.
This PR breaks a lot of tests, and I'm planning to fix them. Let's take on a quick first pass before I fully continue in testing and fixing tests.Now all of them are fixed.Fixes #3