Fix tasks for standalone and fix average progress validation error #463
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit makes figures.sites.get_sites aware of standalone mode The purpose of this is to help make standalone and multisite modes transparent to the bulk of Figures code There are also a couple of minor changes in figures.tasks 1. populate_daily_metrics_next now includes the exception string to the error log entry 2. run_figures_monthly_metrics is now standalone aware. Since only one site is run for standalone, there's no need to spawn the site level function as a subtask
The problem was that the new pipeline workflow did not round enrollments' "progress percent" when averaging for CourseDailyMetrics average_progress fixed floating point field. This commit addresses this
johnbaldwin
requested review from
OmarIthawi,
melvinsoft,
shadinaif and
bryanlandia
as code owners
johnbaldwin
changed the title
johnbaldwin
changed the title
OmarIthawi
approved these changes
Aug 15, 2022
|
@OmarIthawi Thanks for approving! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://appsembler.atlassian.net/browse/BLACK-2554
Fix average progress validation error
The problem was that the new pipeline workflow did not round enrollments' "progress percent" when averaging for CourseDailyMetrics average_progress fixed floating point field. This commit addresses this
Fix site handling for standalone mode
This commit makes figures.sites.get_sites aware of standalone mode. The purpose of this is to help make standalone and multisite modes transparent to the bulk of Figures code
There are also a couple of minor changes in figures.tasks
After this PR, I'll do a PR bump for version to 0.4.3