Fix broken devsite data seeding #460
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* `devsite.seed` was not updated when `figures.backfill` was moved to `figures.pipeline.backfill`. This fixes that issue * `devsite.settings` needed to have `FIGURES` key preset. This was causing devsite seed to fail too * Improved the user creation integrity error by displaying the email address. Users are dynamically generated with `Faker` and sometimes the same email address is used. While not strictly needed, it may help the developer experience a little bit by seeing what email generated caused the collision
johnbaldwin
requested review from
OmarIthawi,
melvinsoft,
shadinaif,
estherjsuh and
bryanlandia
as code owners
OmarIthawi
approved these changes
Jun 1, 2022
|
Thanks @OmarIthawi ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
devsite.seedwas not updated whenfigures.backfillwas moved tofigures.pipeline.backfill. This fixes that issuedevsite.settingsneeded to haveFIGURESkey preset. This was causing devsite seed to fail tooFakerand sometimes the same email address is used. While not strictly needed, it may help the developer experience a little bit by seeing what email generated caused the collision