Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle edge case w/ days to complete, where cert exists w/o enrollment #383

Merged
merged 1 commit into from
Jun 24, 2021
Merged

Handle edge case w/ days to complete, where cert exists w/o enrollment #383

merged 1 commit into from
Jun 24, 2021

Conversation

bryanlandia
Copy link
Contributor

@bryanlandia bryanlandia commented Jun 24, 2021 •
edited
Loading

Change description

Found cases where a GeneratedCertificate existed for a user/course but the CourseEnrollment for user/course no longer existed. Odd edge case breaking calculation of days to complete.

Type of change

  • Bug fix (fixes an issue)
  • New feature (adds functionality)

Development

  • Lint rules pass locally
  • Application changes have been tested thoroughly
  • Automated tests covering modified code pass

Security

  • Security impact of change has been considered
  • Code follows company security practices and guidelines

Code review

  • Pull request has a descriptive title and context useful to a reviewer. Screenshots or screencasts are attached as necessary
  • "Ready for review" label attached and reviewers assigned
  • Changes have been reviewed by at least one other contributor
  • Pull request linked to task tracker where applicable

@bryanlandia bryanlandia marked this pull request as ready for review June 24, 2021 18:11
estherjsuh
estherjsuh approved these changes Jun 24, 2021
View reviewed changes
Copy link
Contributor

@estherjsuh estherjsuh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That is strange case... Perhaps a data miss?

@bryanlandia bryanlandia merged commit b1c377e into master Jun 24, 2021
@OmarIthawi OmarIthawi deleted the bryan/days-to-complete-missing-enrollment branch March 19, 2022 11:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@estherjsuh estherjsuh estherjsuh approved these changes

@johnbaldwin johnbaldwin Awaiting requested review from johnbaldwin

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bryanlandia @estherjsuh