Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't use get_site_ids in backfill_daily_metrics... #381

Merged
merged 1 commit into from
Jun 22, 2021

Conversation

bryanlandia
Copy link
Contributor

@bryanlandia bryanlandia commented Jun 21, 2021

populate_daily_metrics will do that. Just pass site=None if
none passed and task will run for all Sites

Change description

This only affects multisite deployments when using backfill_figutes_daily_metrics, but is a bug introduced and released in 0.4.dev13. We'll need to cut a new one.

Type of change

  • Bug fix (fixes an issue)
  • New feature (adds functionality)

Checklists

Development

  • Lint rules pass locally
  • Application changes have been tested thoroughly
  • Automated tests covering modified code pass

Security

  • Security impact of change has been considered
  • Code follows company security practices and guidelines

Code review

  • Pull request has a descriptive title and context useful to a reviewer. Screenshots or screencasts are attached as necessary
  • "Ready for review" label attached and reviewers assigned
  • Changes have been reviewed by at least one other contributor
  • Pull request linked to task tracker where applicable

populate_figures_metrics will do that.  Just pass site=None if
none passed and task will run for all Sites
@bryanlandia bryanlandia merged commit 121b336 into master Jun 22, 2021
@bryanlandia bryanlandia deleted the bryan/fix-daily-backfill-sites branch June 22, 2021 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants