build and publish figures on pypi #372

OmarIthawi · 2021-06-12T21:01:43Z

This is an initial attempt to publish figures on pypi.

It'll probably not work so I've committed the publish step just to make sure the build can be done.

@johnbaldwin I hope this will be a pleasant surprise for you when you're back 🙂

This has been made from the Figures build and release steps in our confluence docs.

Publish only `1.2.3.dev1` releases

This is still in testing and it's good not to mess up the Figures PyPI so this action will only publish .dev releases as described in the setuptools of Python: https://help.github.com/en/actions/language-and-framework-guides/using-python-with-github-actions#publishing-to-package-registries

One this is tested and working, we'll publish for all releases.

Proposed workflow

This will enable a GitHub-based workflow which is completely different from the previous command line based one:

Update the version in the setup.py and make a PR
Merge the release bump PR
Publish a release on GitHub (done via the GUI)
The release is published automatically on PyPI

The workflow above is different from our PyPI release Runbook.

.github/workflows/python-publish.yml

johnbaldwin · 2021-06-14T09:14:01Z

frontend/src/views/ProgressOverview.js

@@ -72,7 +72,6 @@ class ProgressOverview extends Component {
        label: `${course.name} | ${course.number} | ${course.id}`,
        name: course.name,
        number: course.number,
-        id: course.id,


@OmarIthawi Why do we remove this?

the pipleline breaks due to having duplicate id: course.id in two lines:

johnbaldwin

Yay @OmarIthawi ! Really looking forward to getting this tested with PyPI. Since we've not been deploying to PyPI for our releases and PyPI just has an 0.4.0 release from Dec 2020, I'd say it would be find to iterate to push a series of 0.4.0.devX versions. This is exciting!

those lint warnings turns into errors when running the lint in on the GitHub Actions due to the CI=true environment variable being set to true

This has been made from the Figures build and release steps in our confluence docs. This is still in testing and it's good not to mess up the Figures PyPI so this action will only publish `.dev` releases as described in the setuptools of Python: https://help.github.com/en/actions/language-and-framework-guides/using-python-with-github-actions#publishing-to-package-registries One this is tested and working, we'll publish for all releases. This will enable a GitHub-based workflow which is completely different from the previous command line based one: - Update the version in the `setup.py` and make a PR - Merge the release bump PR - Publish a release on GitHub (done via the GUI) - The release is published automatically on PyPI The workflow above is different from our [PyPI release Runbook](https://appsembler.atlassian.net/wiki/spaces/ED/pages/41550165/New+PyPI+release).

OmarIthawi commented Jun 12, 2021

View reviewed changes