Juniper Upgrade - Fix the front end asset build #353
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There were a couple of problems
1. The multi-build.js would not call the second call in
`require('./build.js')
2. Assets were not being created in the path specified by the
'FIGURES_APP_BUILD' directory
This PR fixes those and sets the default build target, `npm run build`
to build both sets of assets for each of the REM_BASE=10 and REM_BASE=16
environments
johnbaldwin
requested review from
estherjsuh,
grozdanowski,
melvinsoft,
OmarIthawi and
bryanlandia
melvinsoft
approved these changes
May 29, 2021
OmarIthawi
approved these changes
May 30, 2021
|
Awesome to start work today and see this fixed! Was running into an issue last Thu trying to deploy a temp branch to a Hawthorn server |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There were a couple of problems
This PR fixes those and sets the default build target,
npm run buildto build both sets of assets for each of the REM_BASE=10 and REM_BASE=16 environments.