Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reorganize the requirements files for Juniper tox tests #345

Merged
merged 1 commit into from
May 24, 2021

Conversation

johnbaldwin
Copy link
Contributor

The purpose of this commit is to clean up the requirements files. This makes things a bit clearer. We now have a "Juniper community" mode and a "Juniper multisite" mode.

  • We remove Py38 because Juniper needs to run in Py35
  • The juniper_community.txt and juniper_multisite.txt requirements files read from juniper_base.txt. Each of the 'community' and 'multisite' have only the package differences, which at this point is the version/branch of edx-organizations

This PR is in preparation for another PR to improve asset building and testing devsite to support S3 based assets as well as local based assets

@johnbaldwin johnbaldwin force-pushed the john/update-requirements branch from f602859 to 9af0599 Compare May 19, 2021 15:53
The purpose of this commit is to clean up the requirements files. This
makes things a bit clearer. We now have a "Juniper community" mode and a
"Juniper multisite" mode.

* We remove Py38 because Juniper needs to run in Py35
* The `juniper_community.txt` and `juniper_multisite.txt` requirements
files read from `juniper_base.txt`. Each of the 'community' and
'multisite' have only the package differences, which at this point is
the version/branch of `edx-organizations`
@johnbaldwin johnbaldwin force-pushed the john/update-requirements branch from 9af0599 to 66e8b67 Compare May 19, 2021 16:24
@johnbaldwin
Copy link
Contributor Author

johnbaldwin commented May 19, 2021

@thraxil Do you have any idea where test (3.5, py35-juniper) and test (3.8, py38-juniper) are coming from? I've grepd and looked over visual inspection the .github files and tox.ini but can't seem to locate these. I don't see them in other open PRs. Could this be an artifact of me changing the .github/workflows/test.yml file after initially creating the PR?

@johnbaldwin johnbaldwin merged commit 6f0b397 into master May 24, 2021
@johnbaldwin johnbaldwin deleted the john/update-requirements branch May 24, 2021 11:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants