Fixed ViewSets with course id detail views #309
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The problem was that course ids with dots in the name would get part of the url before the course id into the PK for the 'retrieve' call, which provides a detail view of the single course based content. The fix was adding `lookup_value_regex` to the Course based model viewsets As part of this: * Refactored figures/views.py to DRY up code * Added logging when an invalid course id is used as a primary key and purposefully raising a `NotFound` exception instead of an `InvalidKeyError` https://appsembler.atlassian.net/browse/RED-1702
melvinsoft
approved these changes
Dec 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The problem was that course ids with dots in the name would get part of
the url before the course id into the PK for the 'retrieve' call, which
provides a detail view of the single course based content.
The fix was adding
lookup_value_regexto the Course based modelviewsets
As part of this:
purposefully raising a
NotFoundexception instead of anInvalidKeyErrorFor reference, see the DRF DefaultRouter.get_lookup_expr method: https://github.com/encode/django-rest-framework/blob/3.6.3/rest_framework/routers.py#L217-L238
https://appsembler.atlassian.net/browse/RED-1702