Reworked SiteMonthlyMetrics registered users metric #268
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OmarIthawi
approved these changes
Oct 14, 2020
* now use collected total user counts in SiteDailyMetrics.total_user_count for the registered users * This saves expensive database queries * This is more accurate because it preserves historical data. The previous approach captured live data for users for a site and users can be removed from sites * Very rudimentary test coverage added What can be improved: This does not report on users who have enrolled for the current day. We want to avoide querying the Django 'User' model for 'date_joined' because the field is not indexed Test coverage can be improved. This commit just includes very basic coverage
johnbaldwin
force-pushed
the
john/smm-registered-users-fix
branch
from
1d1f518 to
01e5fef
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SiteDailyMetrics.total_user_count for the registered users
previous approach captured live data for users for a site and users can
be removed from sites
What can be improved:
This does not report on users who have enrolled
for the current day. We want to avoide querying the Django 'User' model
for 'date_joined' because the field is not indexed
Test coverage can be improved. This commit just includes very basic
coverage