Fixes CourseDailyMetricsSerializer when average_progress is 1.00 #230
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated CourseDailyMetricsSerializer.average_progress `max_digits` to allow 3 digits. Was previously 2 digits which failed the serializer validation when the `average_progress` value was 1.00. Also updated the `average_progress` field definition to set min and max values. Unfortunately, this validation is not being tested. Did some initial timeboxed investigation, but stopped at time limit of 1 hour. Note here that we need to investigation and make sure validation works. Updated the serializer tests
Codecov Report
@@ Coverage Diff @@
## master #230 +/- ##
=======================================
Coverage 91.29% 91.29%
=======================================
Files 38 38
Lines 1953 1953
=======================================
Hits 1783 1783
Misses 170 170
Continue to review full report at Codecov.
|
OmarIthawi
approved these changes
Jun 26, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated CourseDailyMetricsSerializer.average_progress
max_digitstoallow 3 digits. Was previously 2 digits which failed the serializer
validation when the
average_progressvalue was 1.00.Also updated the
average_progressfield definition to set min and maxvalues. Unfortunately, this validation is not being tested. Did some
initial timeboxed investigation, but stopped at time limit of 1 hour.
Note here that we need to investigation and make sure validation works.
Updated the serializer tests