Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove all edX-specific text from account deletion #856

Closed
wants to merge 1 commit into from
Closed

Remove all edX-specific text from account deletion #856

wants to merge 1 commit into from

Conversation

grozdanowski
Copy link

@grozdanowski grozdanowski commented Mar 22, 2021 •
edited by OmarIthawi
Loading

Fixes RED-1592.

@coveralls
Copy link

coveralls commented Mar 22, 2021 •
edited
Loading

Coverage Status

Coverage decreased (-0.02%) to 40.202% when pulling b55a11e on matej/change-newsite-url into 399393c on main.

OmarIthawi
OmarIthawi suggested changes Mar 23, 2021
View reviewed changes
Copy link

@OmarIthawi OmarIthawi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @grozdanowski. Could you please rebase to open remove the devstack related changes? It's already merged in main: #848

Let me know if I should do the rebase.

@OmarIthawi OmarIthawi marked this pull request as draft March 23, 2021 09:10
@grozdanowski
Copy link
Author

@OmarIthawi if you can rebase that would be amazing

@OmarIthawi OmarIthawi changed the title Matej/change newsite url Remove all edX-specific text from account deletion. Apr 2, 2021
@OmarIthawi OmarIthawi changed the title Remove all edX-specific text from account deletion. Remove all edX-specific text from account deletion Apr 2, 2021
@OmarIthawi OmarIthawi self-requested a review April 2, 2021 15:39
@OmarIthawi OmarIthawi marked this pull request as ready for review April 2, 2021 15:39
@OmarIthawi
Copy link

@grozdanowski Could you please re-open in this new branch? It'll be easier than managing push-forces:

@OmarIthawi OmarIthawi closed this Apr 2, 2021
@OmarIthawi OmarIthawi deleted the matej/change-newsite-url branch April 2, 2021 15:42
@natea natea mentioned this pull request May 13, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OmarIthawi OmarIthawi Awaiting requested review from OmarIthawi

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@grozdanowski @coveralls @OmarIthawi