RED-1877: always skip upstream failing tests in Juniper/Koa #852
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The tests are fixed in https://github.com/edx/edx-platform/pull/27002 but conflicts with Juniper. Skipping until Lilac.
thraxil
approved these changes
Mar 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The failed upstream tests appear to need a decent investment to be fixed. Not worth it unfortunately.
I've checked it in Koa.master and it failed as well. It could have to do with my SQLite version
3.31.1, but I don't want to push more time in it.Those tests are to be fixed in Lilac https://github.com/edx/edx-platform/pull/27002 but the commits are not cleanly cherry-pickable.
RED-1877