Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Namespaces cli as lib/approvals/cli/cli.b #49

Closed
wants to merge 2 commits into from
Closed

Namespaces cli as lib/approvals/cli/cli.b #49

wants to merge 2 commits into from

Conversation

zph
Copy link
Contributor

@zph zph commented Apr 7, 2014

This carries on from discussion in #48.

Refined solution for issue [#47] that namespaces the cli code inside
lib/approvals/cli/ so that there isn't a path issue when run under Bundler.

@markijbema
Copy link
Contributor

👍

@zph
Copy link
Contributor Author

zph commented Apr 7, 2014

@kytrinyx Moved it to base of lib/approvals/cli.rb based on your feedback from #48 😄

@kytrinyx
Copy link
Contributor

kytrinyx commented Apr 7, 2014

Now I'm just being difficult... would you mind squashing the commits?

✨ ❤️ ✨

@zph
Copy link
Contributor Author

zph commented Apr 7, 2014

😆 absolutely
On Apr 7, 2014 1:07 PM, "Katrina Owen" [email protected] wrote:

Now I'm just being difficult... would you mind squashing the commits?

[image: ✨][image: ❤️][image: ✨]


Reply to this email directly or view it on GitHubhttps://github.com//pull/49#issuecomment-39756427
.

kytrinyx and others added 2 commits April 7, 2014 14:17
Refined solution for issue [#47] that namespaces the cli.rb code as
`lib/approvals/cli.rb` so that there isn't a path issue when run under
Bundler.
@zph
Copy link
Contributor Author

zph commented Apr 7, 2014

Squashed!

kytrinyx added a commit that referenced this pull request Apr 7, 2014
@kytrinyx
Copy link
Contributor

kytrinyx commented Apr 7, 2014

Thank you ❤️ merged in 43b84e1

@kytrinyx kytrinyx closed this Apr 7, 2014
@zph zph deleted the issue_47_cont/naming_collision_under_bundler branch October 2, 2014 02:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants