-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Alexa implementation #38
base: master
Are you sure you want to change the base?
Conversation
… a bunch of stuff but at least it does requests and returns hashes. Good to start with.
Hey, looks good! You might want to look at rds.rb and iam.rb which are doing the parsing in a much simpler fashion using xml-simple (no explicit parser required). This will probably be the way we'll do everything from now on as it makes it so much easier. I have no problem bringing your Alexa stuff into the main aws lib either, but please consider simplifying as suggested above. Also, why prefix the methods with alexa_ , like alexa_category_browse, why not just category_browse ? |
Thanks, Ok to both naming issues and parsing with xml-simple. It may take a bit (Decembers are tough) but I'll get to it and add commits to it doing just that. |
Hey, sorry for the delay on this. Can you ensure you're up to date with latest appoxy/aws master and if all good, i'll pull this in. There may be some conflicts with recent commits. |
Hey guys, can you update your branch to latest master and i'll get this in? |
Hi Travis, Having a bit of a problem with the merge since we were using camelize (even had to change it to match the current activesupport) and the activesupport dependency was removed. Not sure where to put the camelization now). Looking to see where this happened and where all the base class extensions went. |
…emoved the AS dependency
Those are in the AwsUtils class now. |
Hi Travis,
This is an experimental Alexa implementation patterned after the EC2 code. The parser is simply a collection of hashes because of the way Alexa groups the responses. I am using it for a project and I wanted to let you know I'm working on it.
I intend to improve the parser as I go, but I had to get back to domain code so I just kept it as is.
Let me know if it's possible to add it (and the upcoming fixes for the parser). I may publish a hackerdude-aws gem with this branch because I need it for projects.
Thanks!