Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GS-485: Get Services working and fix Alerts tests #18

Conversation

solarchad
Copy link
Contributor

@solarchad solarchad commented Sep 24, 2019

This changes the service resource to use the new SDK/client. It fixes alerts too so that it uses the AlertRequest struct (which allows services to be in []int form instead of []*Service form).

All service tests (and now alert tests) are passing (see below).

go test -v                                    
=== RUN   TestProvider
--- PASS: TestProvider (0.00s)
=== RUN   TestProvider_impl
--- PASS: TestProvider_impl (0.00s)
=== RUN   TestAccAppOpticsAlertMinimal
--- PASS: TestAccAppOpticsAlertMinimal (0.82s)
=== RUN   TestAccAppOpticsAlertBasic
--- PASS: TestAccAppOpticsAlertBasic (0.68s)
=== RUN   TestAccAppOpticsAlertFull
--- PASS: TestAccAppOpticsAlertFull (2.53s)
=== RUN   TestAccAppOpticsAlertUpdated
--- PASS: TestAccAppOpticsAlertUpdated (9.42s)
=== RUN   TestAccAppOpticsAlertRename
--- PASS: TestAccAppOpticsAlertRename (9.61s)
=== RUN   TestAccAppOpticsAlertFullUpdate
--- PASS: TestAccAppOpticsAlertFullUpdate (3.88s)
=== RUN   TestAccAppOpticsServiceBasic
--- PASS: TestAccAppOpticsServiceBasic (3.12s)
=== RUN   TestAccAppOpticsServiceUpdated
--- PASS: TestAccAppOpticsServiceUpdated (11.83s)

@solarchad solarchad requested a review from trevrosen September 26, 2019 12:58
@solarchad solarchad merged commit efb612b into chore/AO-11606/use-official-client-chad Sep 26, 2019
@solarchad solarchad deleted the feature/GS-485-resource-services branch September 26, 2019 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants