Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GS-486: Alerts Resource #14

Merged

Conversation

solarchad
Copy link
Contributor

@solarchad solarchad commented Sep 16, 2019

Fixes #1

I was able to create/read/update/destroy the following alert resource:

resource "appoptics_alert" "myalert" {
  name        = "MyAlert"
  description = "A Test Alert"

  # services    = ["${appoptics_service.myservice.id}"]

  condition {
    type        = "above"
    threshold   = 10
    metric_name = "sawmill.go.goroutines"

    tag {
      name    = "hostname"
      grouped = true
      values  = ["12b019bd2da3"]
    }
  }
  active = true
}

@solarchad solarchad changed the base branch from appoptics to chore/AO-11606/use-official-client September 16, 2019 13:47
@solarchad solarchad marked this pull request as ready for review September 18, 2019 12:46
@solarchad solarchad requested a review from trevrosen September 18, 2019 12:47
@solarchad
Copy link
Contributor Author

@trevrosen I got the tests mostly working. It looks like our hunch was correct, the tests are still failing because the alerts tests are referencing the service which uses the librato client still. So I think to resolve the tests, I'll fix up the service stuff next.

@trevrosen
Copy link
Contributor

:shipit: wooooooooo! 🥂 Congrats!

@solarchad solarchad merged commit 12b4c26 into chore/AO-11606/use-official-client Sep 24, 2019
@solarchad solarchad deleted the feature/GS-486-alerts-resource branch September 24, 2019 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants