Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

only construct an element when getFirst does not #885

Merged
merged 4 commits into from
Jan 30, 2018

Conversation

jhsu
Copy link
Collaborator

@jhsu jhsu commented Jan 22, 2018

@codecov-io
Copy link

codecov-io commented Jan 22, 2018

Codecov Report

Merging #885 into master will increase coverage by 0.02%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #885      +/-   ##
==========================================
+ Coverage    89.8%   89.82%   +0.02%     
==========================================
  Files         180      180              
  Lines        3325     3332       +7     
  Branches     1010     1025      +15     
==========================================
+ Hits         2986     2993       +7     
  Misses        321      321              
  Partials       18       18
Impacted Files Coverage Δ
...ts/SearchableMultiSelect/SearchableMultiSelect.jsx 79.56% <100%> (+0.22%) ⬆️
src/components/SearchField/SearchField.jsx 100% <100%> (ø) ⬆️
...mponents/InfiniteSlidePanel/InfiniteSlidePanel.jsx 100% <100%> (ø) ⬆️
src/components/DataTable/DataTable.jsx 100% <100%> (ø) ⬆️
...c/components/LoadingIndicator/LoadingIndicator.jsx 100% <100%> (ø) ⬆️
...c/components/SearchableSelect/SearchableSelect.jsx 82.43% <100%> (+0.24%) ⬆️
src/components/LineChart/LineChart.jsx 73.1% <100%> (+0.22%) ⬆️
src/components/BarChart/BarChart.jsx 83.72% <100%> (+0.38%) ⬆️
src/components/DateSelect/DateSelect.jsx 100% <100%> (ø) ⬆️

@chrisdopuch chrisdopuch self-requested a review January 27, 2018 00:03
Copy link
Contributor

@chrisdopuch chrisdopuch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice thanks Joe!

@ogupte ogupte merged commit 6ad6cdd into appnexus:master Jan 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants