Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exposing data table column width to child components #1235

Merged
merged 2 commits into from
May 17, 2021

Conversation

AndreEPaul
Copy link
Collaborator

@AndreEPaul AndreEPaul commented May 13, 2021

PR Checklist

Storybook can be viewed here

  • Manually tested across supported browsers

    • Chrome
    • Firefox
    • Safari
  • Unit tests written (common at minimum)

  • PR has one of the semver- labels

  • Two core team engineer approvals

  • One core team UX approval

@AndreEPaul AndreEPaul requested review from yasskin and dreidn May 13, 2021 23:12
@AndreEPaul
Copy link
Collaborator Author

AndreEPaul commented May 13, 2021

Since this is a small change, I wasn't sure if any tests needed to be added.

Please let me know if I should add one or add an example table for the usage.

(side note: not sure why TextField.tsx made it into the Codecov Report diff. Didn't make a change there.)

Edit: test case added for passing width along to child component.

@codesandbox-ci
Copy link

codesandbox-ci bot commented May 13, 2021

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@codecov-commenter
Copy link

codecov-commenter commented May 13, 2021

Codecov Report

Merging #1235 (41fc7f7) into master (ecf5163) will decrease coverage by 0.02%.
The diff coverage is 80.00%.

❗ Current head 41fc7f7 differs from pull request most recent head 35b76db. Consider uploading reports for the commit 35b76db to get more accurate results

@@            Coverage Diff             @@
##           master    #1235      +/-   ##
==========================================
- Coverage   89.01%   88.98%   -0.03%     
==========================================
  Files         222      222              
  Lines        5536     5540       +4     
  Branches     1407     1411       +4     
==========================================
+ Hits         4928     4930       +2     
- Misses        590      592       +2     
  Partials       18       18              
Impacted Files Coverage Δ
src/components/DataTable/DataTable.tsx 95.33% <80.00%> (-0.56%) ⬇️
src/components/TextField/TextField.tsx 95.65% <0.00%> (-1.45%) ⬇️

@yasskin yasskin requested a review from tsantef May 14, 2021 18:29
@AndreEPaul AndreEPaul merged commit 2a7af81 into master May 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants