Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Machining Calculators #50

Merged
merged 80 commits into from
Nov 11, 2022
Merged

Machining Calculators #50

merged 80 commits into from
Nov 11, 2022

Conversation

mikecentola
Copy link
Member

Pull Request

Description

Major Feature addition. Adding a WebviewView underneath the stats view that has Speeds & Feeds calculators, Metal Removal Rate and Surface Finish (Lathe only). Also first working code that utilizes the machine type in the configuration.

Issues

#46

Checklist

  • I have followed the guidelines in the Contributing document.
  • I have followed the Code of Conduct for this project.
  • My changes follow the coding style of this project.
  • My changes have been formatted and linted.
  • I have made any relevant changes to the documentation as needed (include CHANGELOG.md and/or README.md).
  • My changes have a descriptive commit message with a short title, including links to issues it addresses.
  • I had fun.

@mikecentola mikecentola linked an issue Sep 28, 2022 that may be closed by this pull request
@mikecentola mikecentola added this to the 0.8 milestone Sep 28, 2022
@mikecentola mikecentola self-assigned this Sep 28, 2022
@mikecentola mikecentola added feature New feature or request webview Webview issues or changes configuration Configuration issues or changes views Views issues or changes commands Extension Commands issues or changes labels Sep 28, 2022
@mikecentola mikecentola merged commit 85465f6 into master Nov 11, 2022
@mikecentola mikecentola deleted the calculator branch November 11, 2022 22:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
commands Extension Commands issues or changes configuration Configuration issues or changes feature New feature or request views Views issues or changes webview Webview issues or changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Milling/Turning Calculators
1 participant