-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change project structure for Poetry and Jupyter-Book ocmpatibility #10
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Still one ToDo open to discuss
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks good and almost done, thank you!
I'm pushing the fixes myself, just for reference
{{cookiecutter.project_name}}/docs/02_notebooks/config_example.ipynb
Outdated
Show resolved
Hide resolved
{{cookiecutter.project_name}}/src/{{cookiecutter.project_name}}/sample_module.py
Outdated
Show resolved
Hide resolved
@@ -10,8 +10,7 @@ | |||
"In this library template, notebooks will be executed with pytest (thus on every\n", | |||
"commit in your CI/CD pipeline). The results of the executions will be saved to the docs directory and converted to\n", | |||
"static websites through nbconvert. The static websites are then added to the documentation under the\n", | |||
"_Guides and Tutorials_ section. These websites will be deployed to gitlab/github pages on push to develop.\n", | |||
"For azure-devops, the CI pipeline currently does not include a deployment of the pages - pull requests are welcome :)" | |||
"_Guides and Tutorials_ section. These websites will be deployed to Github pages on push to develop." |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The output of one of the functions mentions pylint, pls change that text
Also, pls demonstrate how to use references in the nb (like in tianshou)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@carlocagnetta I did the first part, could you add the references pls?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Merging this meanwhile, you can go ahead and use this for the new project!
Virtual env dealt by Poetry
Automatic API documentation
Documentation built in Jupyter-Books
Removed venv
Removed Gitlab CI
Removed Azure Pipeline