Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change project structure for Poetry and Jupyter-Book ocmpatibility #10

Merged
merged 7 commits into from
Feb 27, 2024

Conversation

carlocagnetta
Copy link
Collaborator

@carlocagnetta carlocagnetta commented Feb 27, 2024

  • Virtual env dealt by Poetry

  • Automatic API documentation

  • Documentation built in Jupyter-Books

  • Removed venv

  • Removed Gitlab CI

  • Removed Azure Pipeline

Copy link
Collaborator Author

@carlocagnetta carlocagnetta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still one ToDo open to discuss

Copy link
Collaborator

@MischaPanch MischaPanch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good and almost done, thank you!

I'm pushing the fixes myself, just for reference

{{cookiecutter.project_name}}/pyproject.toml Outdated Show resolved Hide resolved
{{cookiecutter.project_name}}/docs/.gitignore Show resolved Hide resolved
@@ -10,8 +10,7 @@
"In this library template, notebooks will be executed with pytest (thus on every\n",
"commit in your CI/CD pipeline). The results of the executions will be saved to the docs directory and converted to\n",
"static websites through nbconvert. The static websites are then added to the documentation under the\n",
"_Guides and Tutorials_ section. These websites will be deployed to gitlab/github pages on push to develop.\n",
"For azure-devops, the CI pipeline currently does not include a deployment of the pages - pull requests are welcome :)"
"_Guides and Tutorials_ section. These websites will be deployed to Github pages on push to develop."
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The output of one of the functions mentions pylint, pls change that text

Also, pls demonstrate how to use references in the nb (like in tianshou)

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@carlocagnetta I did the first part, could you add the references pls?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merging this meanwhile, you can go ahead and use this for the new project!

README.md Outdated Show resolved Hide resolved
{{cookiecutter.project_name}}/docs/_config.yml Outdated Show resolved Hide resolved
{{cookiecutter.project_name}}/docs/_config.yml Outdated Show resolved Hide resolved
@MischaPanch MischaPanch merged commit 5523ddb into master Feb 27, 2024
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants